Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AI-3796] - Remove the log->source field from the manifest file #17553

Merged
merged 11 commits into from
May 31, 2024
Merged

[AI-3796] - Remove the log->source field from the manifest file #17553

merged 11 commits into from
May 31, 2024

Conversation

dkirov-dd
Copy link
Contributor

@dkirov-dd dkirov-dd commented May 10, 2024 •
edited

What does this PR do?

Remove the log->source field from the manifest file

Motivation

This field is no longer needed as it is redundant with the id field in assets/logs/<INTEGRATION_NAME>.yaml

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dkirov-dd dkirov-dd force-pushed the david.kirov/remove-manifest-log-source branch 2 times, most recently from 37b5ffc to d84b262 Compare May 10, 2024 13:14
@dkirov-dd dkirov-dd force-pushed the david.kirov/remove-manifest-log-source branch from 002c0d4 to dd645bd Compare May 17, 2024 09:17
@dkirov-dd dkirov-dd force-pushed the david.kirov/remove-manifest-log-source branch from 57e3b6f to 6f19a2e Compare May 28, 2024 09:06
@dkirov-dd dkirov-dd marked this pull request as ready for review May 28, 2024 09:15
@dkirov-dd dkirov-dd requested review from a team as code owners May 28, 2024 09:15
@dkirov-dd dkirov-dd requested a review from mx-psi May 28, 2024 09:15
FlorentClarret
FlorentClarret previously approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for Agent platform

mx-psi
mx-psi previously approved these changes May 28, 2024
View reviewed changes
@dkirov-dd dkirov-dd dismissed stale reviews from mx-psi and FlorentClarret via eceb6f8 May 28, 2024 09:41
NouemanKHAL
NouemanKHAL approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @DataDog/platform-integrations

L3n41c
L3n41c approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM for files owned by @DataDog/container-integrations.

@dkirov-dd dkirov-dd merged commit 0ce074f into master May 31, 2024
51 of 52 checks passed
@dkirov-dd dkirov-dd deleted the david.kirov/remove-manifest-log-source branch May 31, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lebot julien-lebot julien-lebot approved these changes

@iliakur iliakur iliakur approved these changes

@L3n41c L3n41c L3n41c approved these changes

@lu-zhengda lu-zhengda lu-zhengda approved these changes

@steveny91 steveny91 steveny91 approved these changes

@NouemanKHAL NouemanKHAL NouemanKHAL approved these changes

@jhgilbert jhgilbert jhgilbert left review comments

@FlorentClarret FlorentClarret FlorentClarret left review comments

@mx-psi mx-psi mx-psi left review comments

Assignees
No one assigned
Labels
changelog/no-changelog dev_package dev/tooling documentation integration/activemq integration/aerospike integration/airflow integration/ambari integration/apache integration/arangodb integration/argo_rollouts integration/argo_workflows integration/argocd integration/azure_active_directory integration/azure_iot_edge integration/boundary integration/cacti integration/calico integration/cassandra integration/ceph integration/checkpoint_quantum_firewall integration/cisco_duo integration/cisco_secure_firewall integration/cisco_umbrella_dns integration/citrix_hypervisor integration/clickhouse integration/cockroachdb integration/confluent_platform integration/consul integration/coredns integration/couch integration/datadog_cluster_agent integration/druid integration/elastic integration/envoy integration/etcd integration/exchange_server integration/flink integration/fluxcd integration/foundationdb integration/gearmand integration/gitlab_runner integration/gitlab integration/glusterfs integration/gunicorn integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/hive integration/hivemq integration/hudi integration/ibm_ace integration/ibm_db2 integration/ibm_mq integration/ibm_was integration/ignite integration/iis integration/impala integration/istio integration/jboss_wildfly integration/jmeter integration/kafka integration/karpenter integration/kong integration/kube_scheduler integration/kyototycoon integration/lighttpd integration/mapr integration/mapreduce integration/marathon integration/marklogic integration/mcache integration/mesos_slave integration/mongo integration/mysql integration/nagios integration/nfsstat integration/nginx_ingress_controller integration/nginx integration/nvidia_triton integration/openldap integration/openstack integration/palo_alto_panorama integration/pan_firewall integration/pgbouncer integration/postfix integration/postgres integration/powerdns_recursor integration/presto integration/proxysql integration/pulsar integration/rabbitmq integration/ray integration/redisdb integration/rethinkdb integration/riak integration/scylla integration/sidekiq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@dkirov-dd @julien-lebot @iliakur @jhgilbert @FlorentClarret @L3n41c @lu-zhengda @mx-psi @steveny91 @NouemanKHAL