Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PCF] Update owners #69572

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

OliverDumrique
Copy link
Contributor

Update owners of the PCF types to the new PCF owning team

Please fill in this template.

Update owners of the PCF types to the new PCF owning team
@typescript-bot
Copy link
Contributor

typescript-bot commented May 10, 2024

@OliverDumrique Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69572,
  "author": "OliverDumrique",
  "headCommitOid": "17daf89ae81fb30659e55f23ea06c28b63dfba10",
  "mergeBaseOid": "f3959f0e4572c224f5d5238dae3418e404b61f95",
  "lastPushDate": "2024-05-10T19:09:21.000Z",
  "lastActivityDate": "2024-05-16T18:17:27.000Z",
  "mergeOfferDate": "2024-05-12T19:36:36.000Z",
  "mergeRequestDate": "2024-05-16T18:17:27.000Z",
  "mergeRequestUser": "OliverDumrique",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "powerapps-component-framework",
      "kind": "edit",
      "files": [
        {
          "path": "types/powerapps-component-framework/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "jopursle",
        "kaushikkaul"
      ],
      "addedOwners": [
        "rarattay",
        "OliverDumrique",
        "CoPrez",
        "pjramirez-ms",
        "Alex-MSFT",
        "mikepenaMS"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-05-12T19:35:56.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2105135469,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 10, 2024
@typescript-bot
Copy link
Contributor

🔔 @jopursle @kaushikkaul — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 12, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 12, 2024
@typescript-bot
Copy link
Contributor

@OliverDumrique: Everything looks good here. I am ready to merge this PR (at 17daf89) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jopursle, @kaushikkaul: you can do this too.)

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label May 13, 2024
@OliverDumrique
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 16, 2024
@typescript-bot typescript-bot merged commit b79b4ff into DefinitelyTyped:master May 16, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Owners This PR adds or removes owners Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants