Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/umami] Fix umami type definitions #69578

Merged
merged 1 commit into from
May 19, 2024

Conversation

manstie
Copy link
Contributor

@manstie manstie commented May 12, 2024

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 12, 2024

@manstie Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 6 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69578,
  "author": "manstie",
  "headCommitOid": "2521b864b6d2822e4a30669693b18f9e9b6b1cd0",
  "mergeBaseOid": "86953d1148f231c8f1c534e4a718ac4fa7888767",
  "lastPushDate": "2024-05-12T08:54:05.000Z",
  "lastActivityDate": "2024-05-19T10:28:21.000Z",
  "mergeOfferDate": "2024-05-12T19:36:21.000Z",
  "mergeRequestDate": "2024-05-19T10:28:21.000Z",
  "mergeRequestUser": "manstie",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "umami",
      "kind": "edit",
      "files": [
        {
          "path": "types/umami/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/umami/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/umami/umami-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ncovercash"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-05-12T19:35:41.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2106171993,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @ncovercash — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 12, 2024
@DangerBotOSS
Copy link

Formatting

The following files are not formatted:

  1. types/umami/umami-tests.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 2521b86

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 12, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 12, 2024
@typescript-bot
Copy link
Contributor

@manstie: Everything looks good here. I am ready to merge this PR (at 2521b86) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ncovercash: you can do this too.)

@manstie
Copy link
Contributor Author

manstie commented May 19, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 19, 2024
@typescript-bot typescript-bot merged commit 4be548b into DefinitelyTyped:master May 19, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants