Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conventional-recommended-bump): remove @types/conventional-recommended-bump for v10 onwards #69580

Conversation

favna
Copy link
Contributor

@favna favna commented May 12, 2024

Removes the types for conventional-recommended-bump because as of v10 the package is written in TS and publishes their own types

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.
  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 12, 2024

@favna Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69580,
  "author": "favna",
  "headCommitOid": "d7446c10375c5bfd9d6c9334755b0ab31593ae0c",
  "mergeBaseOid": "86953d1148f231c8f1c534e4a718ac4fa7888767",
  "lastPushDate": "2024-05-12T13:00:27.000Z",
  "lastActivityDate": "2024-05-15T22:15:27.000Z",
  "mergeOfferDate": "2024-05-15T22:08:37.000Z",
  "mergeRequestDate": "2024-05-15T22:15:27.000Z",
  "mergeRequestUser": "favna",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "conventional-recommended-bump",
      "kind": "delete",
      "files": [
        {
          "path": "types/conventional-recommended-bump/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/conventional-recommended-bump/conventional-recommended-bump-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/conventional-recommended-bump/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/conventional-recommended-bump/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/conventional-recommended-bump/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "JasonHK",
        "favna"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-05-15T22:08:00.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2106239766,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @JasonHK — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 12, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board May 12, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 15, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board May 15, 2024
@favna
Copy link
Contributor Author

favna commented May 15, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 15, 2024
@typescript-bot typescript-bot merged commit 2a16fdd into DefinitelyTyped:master May 15, 2024
4 checks passed
@favna favna deleted the fix/remove-conventional-recommended-bump branch May 15, 2024 22:16
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 16, 2024
@sandersn
Copy link
Contributor

Turns out conventional-changelog-core depends on conventional-recommended-bump. I do not know why CI passed. I'll update conventional-changelog-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants