-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(conventional-recommended-bump): remove @types/conventional-recommended-bump for v10 onwards #69580
fix(conventional-recommended-bump): remove @types/conventional-recommended-bump for v10 onwards #69580
Conversation
…ended-bump for v10 onwards
@favna Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69580,
"author": "favna",
"headCommitOid": "d7446c10375c5bfd9d6c9334755b0ab31593ae0c",
"mergeBaseOid": "86953d1148f231c8f1c534e4a718ac4fa7888767",
"lastPushDate": "2024-05-12T13:00:27.000Z",
"lastActivityDate": "2024-05-15T22:15:27.000Z",
"mergeOfferDate": "2024-05-15T22:08:37.000Z",
"mergeRequestDate": "2024-05-15T22:15:27.000Z",
"mergeRequestUser": "favna",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
},
{
"name": "conventional-recommended-bump",
"kind": "delete",
"files": [
{
"path": "types/conventional-recommended-bump/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/conventional-recommended-bump/conventional-recommended-bump-tests.ts",
"kind": "test"
},
{
"path": "types/conventional-recommended-bump/index.d.ts",
"kind": "definition"
},
{
"path": "types/conventional-recommended-bump/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/conventional-recommended-bump/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"JasonHK",
"favna"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-05-15T22:08:00.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2106239766,
"ciResult": "pass"
} |
🔔 @JasonHK — please review this PR in the next few days. Be sure to explicitly select |
Ready to merge |
Turns out conventional-changelog-core depends on conventional-recommended-bump. I do not know why CI passed. I'll update conventional-changelog-core. |
Removes the types for
conventional-recommended-bump
because as of v10 the package is written in TS and publishes their own typespnpm test <package to test>
.notNeededPackages.json
.