Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @types/mdx-js__react #69583

Merged

Conversation

remcohaszing
Copy link
Contributor

@mdx-js/react 2.0.0 and greater include their own type definitions.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

`@mdx-js/react` 2.0.0 and greater include their own type definitions.
@typescript-bot
Copy link
Contributor

typescript-bot commented May 13, 2024

@remcohaszing Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69583,
  "author": "remcohaszing",
  "headCommitOid": "26fa37144b643065f42cdb2c1d0fb7b3033c72a5",
  "mergeBaseOid": "213785ea0d09abc2b89228d0a810e1597fabb18f",
  "lastPushDate": "2024-05-13T08:42:00.000Z",
  "lastActivityDate": "2024-05-16T06:50:08.000Z",
  "mergeOfferDate": "2024-05-15T22:03:11.000Z",
  "mergeRequestDate": "2024-05-16T06:50:08.000Z",
  "mergeRequestUser": "remcohaszing",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "mdx-js__react",
      "kind": "delete",
      "files": [
        {
          "path": "types/mdx-js__react/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mdx-js__react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mdx-js__react/mdx-js__react-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/mdx-js__react/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mdx-js__react/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ifiokjr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-05-15T22:02:34.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "wooorm",
      "date": "2024-05-13T08:51:26.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2106988562,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits Infrastructure labels May 13, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 13, 2024
@typescript-bot
Copy link
Contributor

🔔 @ifiokjr — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board May 13, 2024
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label May 13, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 15, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board May 15, 2024
@typescript-bot
Copy link
Contributor

@remcohaszing: Everything looks good here. I am ready to merge this PR (at 26fa371) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ifiokjr: you can do this too.)

@remcohaszing
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 16, 2024
@typescript-bot typescript-bot merged commit 34f621f into DefinitelyTyped:master May 16, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 16, 2024
@remcohaszing remcohaszing deleted the remove-mdx-js__react branch May 16, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants