Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebMIDI -- WebMIDI types refactor according to spec update and fixes #69585

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

sy-filis
Copy link

@sy-filis sy-filis commented May 13, 2024

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: URL in every commit description, but mostly MDN and W3C.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 13, 2024

@sy-filis Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 15 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69585,
  "author": "sy-filis",
  "headCommitOid": "215b140583521999f0431f90838a9b116809d7ad",
  "mergeBaseOid": "35ea3e696d3fb324ce0c779d20c2ab83f36d9181",
  "lastPushDate": "2024-05-13T09:24:33.000Z",
  "lastActivityDate": "2024-05-13T12:34:48.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "webmidi",
      "kind": "edit",
      "files": [
        {
          "path": "types/webmidi/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webmidi/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/webmidi/webmidi-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "nakakura"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2107079425,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 13, 2024
@typescript-bot
Copy link
Contributor

🔔 @nakakura — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@sy-filis
Copy link
Author

sy-filis commented May 13, 2024

@nakakura
I do not know if the properties of MIDIOptions has to be required.
According to MDN and W3C they should, but in the lib.dom.d.ts library:779 they are optionals.

fix: midi access listeners change functions return type
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 24, 2024
@typescript-bot
Copy link
Contributor

Re-ping @nakakura:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
New Pull Request Status Board
Waiting for Code Reviews
Development

Successfully merging this pull request may close these issues.

None yet

2 participants