-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebMIDI -- WebMIDI types refactor according to spec update and fixes #69585
base: master
Are you sure you want to change the base?
Conversation
@sy-filis Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 15 days — please try to get reviewers! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69585,
"author": "sy-filis",
"headCommitOid": "215b140583521999f0431f90838a9b116809d7ad",
"mergeBaseOid": "35ea3e696d3fb324ce0c779d20c2ab83f36d9181",
"lastPushDate": "2024-05-13T09:24:33.000Z",
"lastActivityDate": "2024-05-13T12:34:48.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "webmidi",
"kind": "edit",
"files": [
{
"path": "types/webmidi/index.d.ts",
"kind": "definition"
},
{
"path": "types/webmidi/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/webmidi/webmidi-tests.ts",
"kind": "test"
}
],
"owners": [
"nakakura"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2107079425,
"ciResult": "pass"
} |
🔔 @nakakura — please review this PR in the next few days. Be sure to explicitly select |
@nakakura |
fix: midi access listeners change functions return type
Re-ping @nakakura: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
package.json
.