-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Types for react-smartbanner #69590
Conversation
@PCOffline Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69590,
"author": "PCOffline",
"headCommitOid": "f552cd3cce25a0451e739affe1624a37a7b45d61",
"mergeBaseOid": "213785ea0d09abc2b89228d0a810e1597fabb18f",
"lastPushDate": "2024-05-13T13:43:50.000Z",
"lastActivityDate": "2024-05-16T06:55:04.000Z",
"mergeOfferDate": "2024-05-15T21:55:39.000Z",
"mergeRequestDate": "2024-05-16T06:55:04.000Z",
"mergeRequestUser": "PCOffline",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-smartbanner",
"kind": "add",
"files": [
{
"path": "types/react-smartbanner/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/react-smartbanner/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-smartbanner/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/react-smartbanner/react-smartbanner-tests.tsx",
"kind": "test"
},
{
"path": "types/react-smartbanner/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"PCOffline"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-05-15T21:55:02.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2107620155,
"ciResult": "pass"
} |
🔔 @PCOffline — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
Hey @patw0929 @Philin-Anton could you please review this? |
@PCOffline: Everything looks good here. I am ready to merge this PR (at f552cd3) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
pnpm test <package to test>
.The package does not already provide its own types, or cannot have its
.d.ts
files generated via--declaration
If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
Create it with
dts-gen --dt
, not by basing it on an existing project.Represents shape of module/library correctly
tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.