Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cytoscape] Fixes typing of arguments to concentric, levelWidth callbacks #69591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cneumann
Copy link
Contributor

ConcentricLayoutOptions can include two callbacks that are invoked with a single node and all nodes in the layout respectively. The previous typing was based on the example use in the documentation and prevented use of other node properties to be accessed.

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: call to concentric callback with node argument, call to levelWidth callback with all nodes as argument.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

ConcentricLayoutOptions can include two callbacks that are invoked with
a single node and all nodes in the layout respectively. The previous
typing was based on the example use in the documentation and prevented
use of other node properties to be accessed.
@typescript-bot
Copy link
Contributor

typescript-bot commented May 13, 2024

@cneumann Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 15 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69591,
  "author": "cneumann",
  "headCommitOid": "278d86f040b5986c61dadf76b38054c8707ad8b1",
  "mergeBaseOid": "35ea3e696d3fb324ce0c779d20c2ab83f36d9181",
  "lastPushDate": "2024-05-13T15:09:19.000Z",
  "lastActivityDate": "2024-05-13T15:09:19.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "cytoscape",
      "kind": "edit",
      "files": [
        {
          "path": "types/cytoscape/cytoscape-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/cytoscape/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "phreed",
        "wy193777",
        "ypconstante",
        "janniclas",
        "gsbelarus",
        "peterjferrarotto",
        "spaxe",
        "Veckodag",
        "jsve",
        "rogerdubbs"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2107929298,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label May 13, 2024
@typescript-bot
Copy link
Contributor

🔔 @phreed @wy193777 @ypconstante @janniclas @gsbelarus @PeterJFerrarotto @Spaxe @Veckodag @jsve @rogerdubbs — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 13, 2024
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 24, 2024
@typescript-bot
Copy link
Contributor

Re-ping @phreed, @wy193777, @ypconstante, @janniclas, @gsbelarus, @PeterJFerrarotto, @Spaxe, @Veckodag, @jsve, @rogerdubbs:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
New Pull Request Status Board
Waiting for Code Reviews
Development

Successfully merging this pull request may close these issues.

None yet

2 participants