-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[office-js][office-js-preview] (common) Document device permission API #69592
[office-js][office-js-preview] (common) Document device permission API #69592
Conversation
@samantharamon Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69592,
"author": "samantharamon",
"headCommitOid": "279223e2a39d84a9e60c7011f945f5edd3e2f4ea",
"mergeBaseOid": "4bb4074c7626d9ed78c2c5243476539d6dc161b0",
"lastPushDate": "2024-05-13T16:55:05.000Z",
"lastActivityDate": "2024-05-16T18:35:11.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "office-js-preview",
"kind": "edit",
"files": [
{
"path": "types/office-js-preview/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "office-js",
"kind": "edit",
"files": [
{
"path": "types/office-js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Rick-Kirkham",
"date": "2024-05-16T17:30:24.000Z",
"isMaintainer": false
},
{
"type": "stale",
"reviewer": "AlexJerabek",
"date": "2024-05-13T17:33:24.000Z",
"abbrOid": "f9c8afb"
}
],
"mainBotCommentID": 2108222179,
"ciResult": "pass"
} |
🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select |
@AlexJerabek tagging for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions. Please repeat them in the other d.ts file too.
@samantharamon One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
@AlexJerabek Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@AlexJerabek Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
package.json
.