Mark read-only properties in express requests

[alitas]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/expressjs/express/blob/master/lib/request.js>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@alitas Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• express-serve-static-core — on npm, on unpkg
  • owner-approval: @JoseLion

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69605,
  "author": "alitas",
  "headCommitOid": "84ee5609c53902e929c2b54e46c32877ae93166f",
  "mergeBaseOid": "43beba35db4823d72757dfe783bbc5907f679684",
  "lastPushDate": "2024-05-14T15:38:08.000Z",
  "lastActivityDate": "2024-05-21T20:04:19.000Z",
  "mergeOfferDate": "2024-05-21T20:03:53.000Z",
  "mergeRequestDate": "2024-05-21T20:04:19.000Z",
  "mergeRequestUser": "alitas",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "express-serve-static-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-serve-static-core/express-serve-static-core-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/express-serve-static-core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "borisyankov",
        "micksatana",
        "samijaber",
        "JoseLion",
        "dwrss",
        "andoshin11"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-05-21T20:03:17.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "JoseLion",
      "date": "2024-05-20T02:53:44.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2110556760,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @borisyankov @micksatana @samijaber @JoseLion @dwrss @andoshin11 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[JoseLion]

LGTM! Nice improvement 🚀

[peterblazejewicz]

@alitas thanks!

[typescript-bot]

@alitas: Everything looks good here. I am ready to merge this PR (at 84ee560) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@borisyankov, @micksatana, @samijaber, @JoseLion, @dwrss, @andoshin11: you can do this too.)

[alitas]

Ready to merge