-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten: Added more types #69611
Emscripten: Added more types #69611
Conversation
Changed registerDevice to use Partial<StreamOps> Added missing option to lookupPath
@dr-vortex Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69611,
"author": "dr-vortex",
"headCommitOid": "a7722a62ac3734eef455141096a5b3ef929bc3f6",
"mergeBaseOid": "43beba35db4823d72757dfe783bbc5907f679684",
"lastPushDate": "2024-05-14T18:09:43.000Z",
"lastActivityDate": "2024-05-28T19:49:08.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2024-05-28T19:44:27.000Z",
"mergeRequestDate": "2024-05-28T19:49:08.000Z",
"mergeRequestUser": "dr-vortex",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "emscripten",
"kind": "edit",
"files": [
{
"path": "types/emscripten/emscripten-tests.ts",
"kind": "test"
},
{
"path": "types/emscripten/index.d.ts",
"kind": "definition"
}
],
"owners": [
"zakki",
"periklis",
"kbumsik",
"lourd"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "lourd",
"date": "2024-05-28T01:21:43.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2110829770,
"ciResult": "pass"
} |
🔔 @zakki @periklis @kbumsik @lourd — please review this PR in the next few days. Be sure to explicitly select |
@dr-vortex: Everything looks good here. I am ready to merge this PR (at a7722a6) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
The PR adds additional types to the
@types/emscripten
package. The types were created by observing implementations in emscripten:src/library_fs.js, emscripten:src/library_memfs.js, and other Emscripten source files.I've tested the changes using
pnpm test emscripten
and by replacing the files innode_modules
and they work as intended.Proactively pinging:
@lourd (@types/emscripten)
@brendandahl (Emscripten)
@kripken (Emscripten)