Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten: Added more types #69611

Merged
merged 4 commits into from
May 28, 2024
Merged

Conversation

dr-vortex
Copy link
Contributor

@dr-vortex dr-vortex commented May 14, 2024

The PR adds additional types to the @types/emscripten package. The types were created by observing implementations in emscripten:src/library_fs.js, emscripten:src/library_memfs.js, and other Emscripten source files.

I've tested the changes using pnpm test emscripten and by replacing the files in node_modules and they work as intended.

Proactively pinging:
@lourd (@types/emscripten)
@brendandahl (Emscripten)
@kripken (Emscripten)

Changed registerDevice to use Partial<StreamOps>
Added missing option to lookupPath
@typescript-bot
Copy link
Contributor

typescript-bot commented May 14, 2024

@dr-vortex Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69611,
  "author": "dr-vortex",
  "headCommitOid": "a7722a62ac3734eef455141096a5b3ef929bc3f6",
  "mergeBaseOid": "43beba35db4823d72757dfe783bbc5907f679684",
  "lastPushDate": "2024-05-14T18:09:43.000Z",
  "lastActivityDate": "2024-05-28T19:49:08.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-05-28T19:44:27.000Z",
  "mergeRequestDate": "2024-05-28T19:49:08.000Z",
  "mergeRequestUser": "dr-vortex",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "emscripten",
      "kind": "edit",
      "files": [
        {
          "path": "types/emscripten/emscripten-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/emscripten/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "zakki",
        "periklis",
        "kbumsik",
        "lourd"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "lourd",
      "date": "2024-05-28T01:21:43.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2110829770,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels May 14, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 14, 2024
@typescript-bot
Copy link
Contributor

🔔 @zakki @periklis @kbumsik @lourd — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 14, 2024
dr-vortex added a commit to zen-fs/emscripten that referenced this pull request May 14, 2024
@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label May 14, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 14, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 14, 2024
@dr-vortex
Copy link
Contributor Author

@zakki @periklis @kbumsik @lourd Could you please review this PR?

dr-vortex added a commit to zen-fs/emscripten that referenced this pull request May 21, 2024
@dr-vortex
Copy link
Contributor Author

dr-vortex commented May 24, 2024

@zakki @periklis @kbumsik @lourd It has been 10 days Could you please review this PR when you have time? Thanks!

- JP

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 25, 2024
@typescript-bot
Copy link
Contributor

typescript-bot commented May 25, 2024

Re-ping @zakki, @periklis, @kbumsik:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 28, 2024
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 28, 2024
@typescript-bot typescript-bot added Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 28, 2024
@typescript-bot
Copy link
Contributor

@dr-vortex: Everything looks good here. I am ready to merge this PR (at a7722a6) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@zakki, @periklis, @kbumsik, @lourd: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 28, 2024
@dr-vortex
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 28, 2024
@typescript-bot typescript-bot merged commit d8da2b7 into DefinitelyTyped:master May 28, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants