[WebXR] Add hapticActuators to gamepad on XRInputSource

[sorskoot]

Add haptic actuators to the gamepad and include pulse function.

• https://w3c.github.io/gamepad/extensions.html#partial-gamepadhapticactuator-interface
• https://developer.mozilla.org/en-US/docs/Web/API/GamepadHapticActuator/pulse

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.

• Test the change in your own code. (Compile and run.)

• Add or edit tests to reflect the change.

• Follow the advice from the readme.

• Avoid common mistakes.

• Run pnpm test <package to test>.

• Provide a URL to documentation or source code which provides context for the suggested changes: <>

• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

[typescript-bot]

@sorskoot Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• webxr — on npm, on unpkg (author is owner)

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 13 days — please try to get reviewers!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69613,
  "author": "sorskoot",
  "headCommitOid": "155c25164847c7463eb8b45c280b1df9b647cd9b",
  "mergeBaseOid": "bfdcd1c2bad2ed372ebf698103824f4171e5e972",
  "lastPushDate": "2024-05-15T06:36:34.000Z",
  "lastActivityDate": "2024-05-22T16:00:31.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "webxr",
      "kind": "edit",
      "files": [
        {
          "path": "types/webxr/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webxr/webxr-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "robrohan",
        "RaananW",
        "capnmidnight",
        "sorskoot"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2111691459,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @robrohan @RaananW @capnmidnight — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[RaananW]

Whereas I can see why it does make sense to have it here, I am not sure it is the right place to include it, as this is an extension of the gamepad module, and not a webxr specific feature. I will wait for others to comment on that as well.

[RaananW]

This should probably be optional? This is not supported by all implementations. And the initial value (per specs) is undefined

[sorskoot]

The reason I added it to this type is that, while the hapticActuators property is still experimental, it is often used with VR controllers. I always have to add some extra type information to avoid errors in my code. Other people in the community have mentioned this as well.

The definition of the gamepad API itself is not a part of DT. Do you think it's better to add a separate type for the Gamepad API to DT to incorporate this?

[RaananW]

The reason I added it to this type is that, while the hapticActuators property is still experimental, it is often used with VR controllers. I always have to add some extra type information to avoid errors in my code. Other people in the community have mentioned this as well.

The definition of the gamepad API itself is not a part of DT. Do you think it's better to add a separate type for the Gamepad API to DT to incorporate this?

Sorry, I didn't mean to delay the merge so much. Was just waiting for feedback from others.
I personally think it belongs in a different types file (or, TBH, in typescript's lib.dom directly). However, I'll follow your lead here - if you think it belongs here i'll approve it (maybe with addressing my one comment up there :-) ). If you want to submit a different PR (types/gamepad or something like that) I will be happy to comment on the new PR.

[typescript-bot]

Re-ping @robrohan, @RaananW, @capnmidnight:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!