Merge pull request #263 from MaddTheSane/oobArray

Fix a couple of out-of-bounds warnings found by Clang.

Descent3/Mission.cpp

@@ -1013,7 +1013,7 @@ bool LoadMission(const char *mssn) {
           for (int a = 0; a < MAX_MISSION_URL_COUNT; a++) {
             if (Net_msn_URLs.URL[a][0] == '\0') {
               strncpy(Net_msn_URLs.URL[a], operand, MAX_MISSION_URL_LEN - 1);
-              Net_msn_URLs.URL[a][MAX_MISSION_URL_LEN] = '\0';
+              Net_msn_URLs.URL[a][MAX_MISSION_URL_LEN - 1] = '\0';
               mprintf((0, "Found a Mission URL: %s\n", operand));
               break;
             }

netcon/includes/con_dll.h

@@ -1167,9 +1167,9 @@ int StartMultiplayerGameMenu() {
       if (!mi)
         break;
       strncpy(DLLNetgame->mission, mi->msn_file, MSN_NAMELEN);
-      DLLNetgame->mission[MSN_NAMELEN] = '\0';
+      DLLNetgame->mission[MSN_NAMELEN - 1] = '\0';
       strncpy(DLLNetgame->mission_name, mi->msn_name, MISSION_NAME_LEN);
-      DLLNetgame->mission_name[MISSION_NAME_LEN] = '\0';
+      DLLNetgame->mission_name[MISSION_NAME_LEN - 1] = '\0';
 #else
       // strcpy(DLLNetgame->mission,DLLListGetSelectedIndex(list_1)?"thecore.d3l":"polaris.d3l");
 

scripts/AIGame.cpp

@@ -5730,7 +5730,6 @@ bool GuideBot::DoInit(int me, bool f_reinit) {
     memory->powerups[2] = 0;
     memory->powerups[3] = 0;
     memory->powerups[4] = 0;
-    memory->powerups[5] = 0;
 
     for (i = 0; i < NUM_GB_SOUNDS; i++) {
       memory->sounds[i] = -1;