Reorganizing fix library #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is requiring zlib1.dll in installdir. Is this intentional? (Debug/windows) -- game runs fine otherwise. |
Arcnor
reviewed
Apr 30, 2024
| @@ -100,9 +97,6 @@ void InitMathTables() { | |||
|
|
|||
| asin_table[256] = asin_table[255]; | |||
| acos_table[256] = acos_table[255]; | |||
|
|
|||
| // Initialize a random seed. | |||
| ps_srand(time(NULL)); | |||
There was a problem hiding this comment.
So this is not needed to initialize the random number generator?
There was a problem hiding this comment.
they relocated seed initialization to init.cpp
There was a problem hiding this comment.
Random seed was injected into InitMathTables when it was part of vecmat submodule. Logically seed initialization not belongs to vecmat or fixmat components so I decided to move it out to common initialization function.
Fix most of "narrowing conversion" warnings.
Seem this was done to ease linking mission dlls. Now these missions are reusing fix as static library.
Seems this is totally unrelated to fix library API. Moved ps_srand() to appropriate places right after InitMathTables();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed point math library was part of the Vector math library until it was splitted to its own. Before that there was bundled version of vecmat code in scripts. This PR makes the library an isolated submodule that can be linked to any other.
Additional enhancements includes fixing minor warnings and removing unused Mac OS and Windows asm code.