Use vector instead of array, and proper referencing #196
Conversation
Instead of using a hardcode-size array for app instances, use a vector instead. This cleans up some bad referencing as well.
Enable DebugAsan builds so we can begin using ASAN without turning it on for the whole debug build.
|
CMakeLists.txt conflict needs resolved. Does this PR actually solve any compilation or runtime problem ? |
|
CMakeLists.txt changes are not related and failing Windows build. Please remove them from PR. |
|
In addition, please refrain from refactoring complete files when not absolutely necessary. We don't have a full testing pipeline right now, we're just trying really hard to get the base game working, and full file refactors can easily introduce problems. I'd prefer a simpler fix for getting Asan to work if possible. Thanks! |
Feel free to re-open with a simpler fix! |
Instead of using a hardcode-size array for app instances, use a vector instead. This cleans up some bad referencing as well.