Clean up and modernize DDIO #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterheart
reviewed
Apr 28, 2024
| inline int ddio_DeleteFile(std::filesystem::path const &path) { | ||
| std::error_code ec{}; | ||
| std::filesystem::remove(path, ec); | ||
| return ec ? 0 : 1; |
There was a problem hiding this comment.
Well, I think we can change function signature here to bool ddio_DeleteFile(std::filesystem::path const &path)
There was a problem hiding this comment.
haha yeah, my initial goal a couple days ago was to do this very piecemeal, but have since become more aggressive with the changes
Begin replacing per-platform DDIO logic with std::filesystem.
Begin replacing custom string manipulation within CFILE with std::filesystem.
|
@tophyr Let's stick with internal functions of DDIO on first run. CFILE changes a little bit intrusive to API. |
Closing for now, feel free to re-open with lighter changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Modernize DDIO and minimize the amount of platform-specific code necessary.
TODO