Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 Bit-Safe Updates #233

Merged
merged 16 commits into from May 4, 2024
Merged

64 Bit-Safe Updates #233

merged 16 commits into from May 4, 2024

Conversation

jcoby
Copy link
Contributor

@jcoby jcoby commented Apr 29, 2024

Imported Icculus' 64-bit changes.

Changes [un]signed long data types to [un]signed int.

Imported Icculus' 64-bit changes.

Changes `[un]signed long` data types to `[un]signed int`.
lib/pstypes.h Outdated Show resolved Hide resolved
@JeodC JeodC added the needs testing Needs testing to confirm issue or resolution label Apr 29, 2024
@JeodC JeodC requested a review from Arcnor April 29, 2024 23:38
@GravisZro
Copy link
Contributor

Why not replace these with standard sized types? (e.g. in32_t and uint32_t)

@JeodC JeodC added the 64bit Issue or pull relates to 64bit label May 3, 2024
Copy link
Member

@JeodC JeodC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine on windows

@JeodC JeodC merged commit 52e66c3 into DescentDevelopers:main May 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
64bit Issue or pull relates to 64bit needs testing Needs testing to confirm issue or resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants