Fix mercenary features

[JeodC]

Pull Request Type

• GitHub Workflow changes
• Documentation or Wiki changes
• Build and Dependency changes
• Runtime changes
  • Render changes
  • Audio changes
  • Input changes
  • Network changes
  • Other changes

Description

This pull modifies how the game detects mercenary installation. Only Win32 had been properly implemented, and in many cases the registry values the game checked for do not exist. Mercenary must still be present to use the Black Pyro ship in multiplayer.

The source previously only attempted to load hogfiles extra.hog and merc.hog. On CD installations, this file combination is present. However, in digital installations, the file combination is extra1.hog and extra.hog. This pull also correctly detects both combinations.

Fixes #255

Checklist

• I have tested my changes locally and verified that they work as intended.
• I have documented any new or modified functionality.
• I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Tested in windows only. Needs multiplatform testing. If the Mercenary hogfile is loaded, the player should be able to select the Black Pyro at the pilot config screen, provided they have cleared Mercenary Level 2. Also, when using the Black Pyro, the guidebot should be red.

[Lgt2x]

How can I test this fix ?

[JeodC]

How can I test this fix ?

See the additional comments. You must have cleared Mercenary Level 2. The Black Pyro should then be selectable at the pilot config screen, and on Merc Level 3 (and any level using the Black Pyro), the guidebot should be red.

[JeodC]

You could try the Debug build too, I think that lets you pick any level at New Game.

[JeodC]

Merging this--it has been tested on windows and should, in theory, work the same way on linux and mac. If it does not, separate issues can be opened.