Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a copy of the GPL to CI artifacts #281

Closed
wants to merge 1 commit into from
Closed

Add a copy of the GPL to CI artifacts #281

wants to merge 1 commit into from

Conversation

Jayman2000
Copy link
Contributor

@Jayman2000 Jayman2000 commented May 3, 2024 •
edited

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

The GPL requires that you include a copy of the GPL with every copy of programs that are released under the GPL. Before this change, CI artifacts didn’t include a copy of the GPL.

Related Issues

Fixes #276

Checklist

  • I have tested my changes locally in CI and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@JeodC
Copy link
Collaborator

JeodC commented May 3, 2024

Thank you, but we will take care of this in #242 which will be resolved sometime this weekend.

@JeodC JeodC added the workflow Modifications to the github workflows label May 3, 2024
@Lgt2x
Copy link
Collaborator

Lgt2x commented May 3, 2024

CI needs this change to run so we can check artifact :)

@Jayman2000
Copy link
Contributor Author

CI needs this change to run so we can check artifact :)

That’s kind of annoying. Luckily, I was able to manually trigger CI for this PR here: https://github.com/Jayman2000/Descent3-pr/actions/runs/8944229931

@Lgt2x
Copy link
Collaborator

Lgt2x commented May 3, 2024

The changes mentioned have just been merged, you can rebase to hopefully have artifacts

@Jayman2000
Add a copy of the GPL to CI artifacts
9cc30b6 
The GPL requires that you include a copy of the GPL with every copy of
programs that are released under the GPL [1]. Before this change, CI
artifacts didn’t include a copy of the GPL.

Fixes DescentDevelopers#276.

[1]: <https://www.gnu.org/licenses/gpl-faq.en.html#WhyMustIInclude>
@JeodC JeodC mentioned this pull request May 3, 2024
Closed
9 tasks
@JeodC
Copy link
Collaborator

JeodC commented May 3, 2024

Superseded by #284

@JeodC JeodC closed this May 3, 2024
This was referenced May 4, 2024
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
workflow Modifications to the github workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI artifacts are missing a copy of the GPL
3 participants
@Jayman2000 @JeodC @Lgt2x