Disable hashtag navigation for avoiding redundant fetching #2083
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this disables the navigation of the UI from a hashtag it is in currently to the same hashtag
Dimillian
reviewed
May 23, 2024
| @@ -134,13 +135,25 @@ public enum SettingsStartingPoint { | |||
|
|
|||
| public var path: [RouterDestination] = [] | |||
| public var presentedSheet: SheetDestination? | |||
| public var currentDestination: RouterDestination? | |||
There was a problem hiding this comment.
You don't need that path.last will give you exactly what you need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you can navigate to the same hashtag that you are currently at, which ultimately can lead to memory bloating and, if done too many times, can freeze or crash the app. To better understand the situation I am referring to, check the linked issue.
This hopefully fixes the issue, modifying the
Routerfile inside theEnvpackage. These modifications disable navigation from the same destination you are currently at, it can be either hashtags (case-insensitively), user profiles, etc. Hopefully I am not introducing any bugs or performance issues!