WIP: Fix saving files with the same names #1812
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dkaraush Do you remember or could you help with understanding why do we need this removed code here?
For me it looks like speed boost/optimization because we don't touch FilePathDatabase in this case - is it correct?
Because of the code there is the bug in the app:
https://bugs.telegram.org/c/35162
https://bugs.telegram.org/c/32951
when there is more than one file with the same name we could "save to downloads" only the first of the cached files, because other files are saved internally with suffix " (number)" (see FileLoadOperation)
So it seems like we have to get file path from FilePathDatabase, where the file path is saved properly (see putPath) - is it correct?