DYN-777 : performance improvements demo #12055
Conversation
|
|
||
| private void ViewNode_MouseEnter(object sender, System.Windows.Input.MouseEventArgs e) | ||
| { | ||
| ConstructView(); |
There was a problem hiding this comment.
so this is a little worrying - I think we'd want to add this to some base class to help authors not need to do this themselves, and we'll call ConstructView or whatever for them?
There was a problem hiding this comment.
something like that yes, we'll need a better mechanism to handle this different than mouse enter event
|
|
||
| private void NodeView_MouseEnter(object sender, MouseEventArgs e) | ||
| { | ||
| PrepareInOutPortsControls(); |
There was a problem hiding this comment.
what about destroying the ports control as well after zoom out or something to free up memory?
|
@BogdanZavu I'm going to mark this draft, it seems to be making the tests run for a long time, if you plan to continue it then mark it ready. |
|
@mjkkirschner I don't plan on continuing with this, for now. Sorry, I just have made it a draft in the first place. |
We don't always need to execute UI-related code and render UI components.
So we are going to load UI elements for nodes ( main content plus ports ) on demand when the user sets focus on a specific control.
If we are doing this Dynamo is ~= 50% faster when we are opening a graph and consumes ~= 50% less memory.
UI-less performance should be improved as well but probably not that much.
Note that even if full UI components are not loaded and a node looks empty graph execution works as expected.
Another nice aspect of this is that this work can be done incrementally one control after another.