DYN-6427 & DYN-6828 Graph Properties UI Fixes #15200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6427
UI Smoke TestsTest: success. 2 passed, 0 failed. |
twastvedt
approved these changes
May 7, 2024
pinzart90
reviewed
May 9, 2024
| Utility.DispatcherUtil.DoEventsLoop(() => | ||
| { | ||
| images = WpfUtilities.ChildrenOfType<Image>(view.NodesInfoDataGrid); | ||
|
|
There was a problem hiding this comment.
This is an attempt to stabilize the test. I merged it here because seems to be able to reproduce it quite consistently
twastvedt
approved these changes
May 20, 2024
Enzo707
pushed a commit
to Enzo707/Dynamo
that referenced
this pull request
May 22, 2024
Co-authored-by: Trygve Wastvedt <trygve.wastvedt@autodesk.com> Co-authored-by: pinzart90 <tiberiu.pinzariu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes two data loss bugs with Graph Properties View Extension interaction.
First is the scenario when you have graph properties defined in a graph but open a custom node. When you return to the graph and save the graph properties are lost. This GraphMetaDataView extension is updated here to handle this case when the Workspace is cleared or changed.
Second is related to naming auto-naming the custom properties. You adding a deleting you can get into a scenario where the logic suggest the same property name. This PR adjust the logic to insure unique auto properties names
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Custom properties in the Graph Properties Extension had an issue where opening a custom node would clear custom properties present in the open graph file. Now custom properties are not impacted by opening a custom node in session.
Custom properties in the Graph Properties Extension had an issue where the automatic naming when adding a new property would produce identical property names in some situations. Now custom properties will always produce a unique name when adding a new custom property.
Reviewers
@twastvedt @BogdanZavu
FYIs
@jnealb