-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty query term conditions #6227
base: 4.x
Are you sure you want to change the base?
Fix empty query term conditions #6227
Conversation
a553334
to
172498d
Compare
@javiereguiluz This PR is the correct fix for #6223 #6242 must be reverted (it breaks postgres) and replaced by this PR. See details in #6262 |
@guillaume-sainthillier could you commit revert of #6242 in this PR? |
172498d
to
206966a
Compare
done |
This PR was merged into the 4.x branch. Discussion ---------- Fixed invalid DQL Fixes #6223 When searching text having only integer fields, an invalid DQL like `SELECT entity FROM App\Entity\Product entity WHERE ` is generated because there are no any `$queryTermConditions`. This PR should fix the issue. Commits ------- 6511215 Fixed invalid DQL
206966a
to
4ea1c86
Compare
Hello @Seb33300, any updates about this PR? Does I need to add something? |
Hi @guillaume-sainthillier, I just tried to help by reviewing it but I am not a maintainer of the project. |
When only numeric fields are searchable,
EntityRepository::addSearchClause
generates a bugged DQL when search contains only non numeric terms.