Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create CODE_OF_CONDUCT-ms.md (Malay review requested) #10915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pizofreude
Copy link

What does this PR do?

Add resource

For resources

Description

This PR adds a translation of "CODE_OF_CONDUCT.md" document in Malay (MY) language for the Free-Programming-Books repository and followed the file naming convention "CODE_OF_CONDUCT-my.md" as indicated. The document provides an overview of Code of Conduct to the repository and serves as a guidelines to ensure safe environment for both new and experienced contributors.

Why is this valuable (or not)?

The Malay translation of the "CODE_OF_CONDUCT.md" is valuable because it makes the repository more inclusive and accessible to Malay-speaking contributors such as Malaysian, Singaporean, and Bruneian. It lowers the entry barrier for new contributors by providing guideline of Code of Conduct in native Malay language that enhances the safety and overall user experience.

How do we know it's really free?

This is my personal translation contribution without using paid third party services. Hence it is free to use.

For book lists, is it a book? For course lists, is it a course? etc.

No, this is just translation of the original CODE_OF_CONDUCT.md into Malay language as found in CODE_OF_CONDUCT-my.md

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@eshellman
Copy link
Collaborator

language code is ml, not my please change the file name. Requesting malay review.

@eshellman eshellman added help wanted Needs help solving a blocked / stucked item 🗣️ locale:ml Resources addressing "Malayalam / മലയാളം" language waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 31, 2023
@eshellman eshellman changed the title feat: create CODE_OF_CONDUCT-my.md feat: create CODE_OF_CONDUCT-my.md (Malay review requested) Oct 31, 2023
@speedosmodel
Copy link

language code is ml, not my please change the file name. Requesting malay review.

Good day, sir, but would you still need the markdown file file:CODE_OF_CONDUCT-my.md be thorougly translated into English?

There is a markdown file file:CODE_OF_CONDUCT under the same directory that I've looked through, and this is the English counterpart of the CODE_OF_CONDUCT.

Pardon for my weird comment, I'm still not used to using Markdown as a language 🤣

@pizofreude
Copy link
Author

My translation is not malayam. It's Malay language, spoken by Malaysian, Singaporean, Bruneian and many other southeast Asian countries. I used ISO 3166 code | MY for most of my translation works which is MY for Malay language even in CrowdIn. There are many ISO standards for language translation. I think we need to specify ISO standard used for translation in the docs of this project to avoid confusion for contributors in the future.

Reference:

https://en.wikipedia.org/wiki/Malaysia
https://www.languagecomparison.com/en/malaysian-language-code/model-36-9

@eshellman eshellman removed the 🗣️ locale:ml Resources addressing "Malayalam / മലയാളം" language label Oct 31, 2023
@eshellman
Copy link
Collaborator

My mistake, language code for Malay is ms. You are welcome to create translations for Malay using ms, but we will not merge them until we have resource lists for Malay. https://www.loc.gov/standards/iso639-2/php/code_list.php

@eshellman eshellman changed the title feat: create CODE_OF_CONDUCT-my.md (Malay review requested) feat: create CODE_OF_CONDUCT-ms.md (Malay review requested) Oct 31, 2023
Copy link

@Abhijeetbyte Abhijeetbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good !

@Ajay-singh1
Copy link
Contributor

@eshellman The Translation For Malay Language is accurate I have checked it using Ai Tools like ChatGPT etc.

@pizofreude
Copy link
Author

Do I need to create a new PR with changes from MY to MS or how do you propose I do the filename changes?

@Ajay-singh1
Copy link
Contributor

No you don't need to open a new PR just change the file name from my.md to ms.md.

@Ajay-singh1
Copy link
Contributor

@eshellman What are your thoughts on this.

@eshellman
Copy link
Collaborator

eshellman commented Nov 1, 2023

you can keep the PR, just change the file name.
I wouldn't trust ChatGPT's "knowledge" of Malay

@muazmohdnasir
Copy link

This looks like Bahasa Indonesia instead of Malay

@eshellman
Copy link
Collaborator

@muazmohdnasir Thanks for looking at it. We have -id translations already. Should we close this?

@pizofreude
Copy link
Author

For reference, I'm a Malay with Malaysian nationality. Defo not Indonesian.

@pizofreude
Copy link
Author

Filename changes made for CODE_OF_CONDUCT-my.md to CODE_OF_CONDUCT-ms.md according to ISO639-2

Copy link
Contributor

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me! Wait for final approval

@eshellman
Copy link
Collaborator

marking this as "keep", which means we'll merge once we add a list of malay resources. We merged translations for Kannada this year, a year after they were finalized.

@eshellman eshellman added keep Requests exempt from being punctually stale and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Nov 2, 2023
@dennismuchene
Copy link

www.google.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Needs help solving a blocked / stucked item keep Requests exempt from being punctually stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants