Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #5176 #5177

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Fixing issue #5176 #5177

merged 1 commit into from
Nov 21, 2020

Conversation

computamike
Copy link
Contributor

What does this PR do?

Fixes rendering issues with Pipes within links

Why is this valuable (or not)?

Issue #5176 identified an issue with the screencasts(en) page - however, this same issue has been identified on other pages, and has been fixed.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Followup

  • Check the output of Travis-CI for linter errors!

@computamike
Copy link
Contributor Author

Some additional comments :

The following Regular expression was used to scan the codebase to find other instances of this issue :

^(.*)(\[)(.*)(\|)(.*)(\])

and the following was used to escape the | character (this was done using VS Code's regex replace)
$1$2$3\|$5$6
Screenshot from 2020-11-21 03-02-10
This could be useful to add to the linter to identify where this would break rendering, or to scan and fix the codebase at a later date.

@computamike computamike marked this pull request as ready for review November 21, 2020 03:03
@shabab477
Copy link
Contributor

Interesting fix. This PR LGTM. I feel like there should be a fix in the linter too.

@computamike
Copy link
Contributor Author

Interesting fix. This PR LGTM. I feel like there should be a fix in the linter too.

Have raised an issue in the linter for this.

@eshellman
Copy link
Collaborator

This is awesome @computamike ! Thanks!

@eshellman eshellman merged commit fb36239 into EbookFoundation:master Nov 21, 2020
tt512 pushed a commit to tt512/free-programming-books that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants