Moved English link #5189
Merged
Moved English link #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'View the English list' link is easy to miss at the top - especially on the https://ebookfoundation.github.io site because the links are much smaller there. The link is squashed in under the main title and before the Intro title - so skimming the page skips over the link. But then if you miss this link you come to the title 'In Other Written Languages' which then makes no sense - because you can't see the English list anywhere. I've create a 'Books' section so that its similar to the 'Free Online Courses' and 'Cheat Sheets' and then put the English link at the top. This seems more logical and easier to skim.
|
I think my PR is a lot less ambitious than the other two. I tried to keep this as small as possible. Also I don't think that you need jump to top links in the README only in the actual book pages. The split into directories would change the URLs but hopefully moving the link shouldn't impact that too much. I agree with your comment to split by topic rather than language - it then still matches the README structure you have now. |
|
Great, thanks for merging! |
tt512
pushed a commit
to tt512/free-programming-books
that referenced
this pull request
May 7, 2021
The 'View the English list' link is easy to miss at the top - especially on the https://ebookfoundation.github.io site because the links are much smaller there. The link is squashed in under the main title and before the Intro title - so skimming the page skips over the link. But then if you miss this link you come to the title 'In Other Written Languages' which then makes no sense - because you can't see the English list anywhere. I've create a 'Books' section so that its similar to the 'Free Online Courses' and 'Cheat Sheets' and then put the English link at the top. This seems more logical and easier to skim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve repo
For resources
Description
The 'View the English list' link is easy to miss at the top - especially on the https://ebookfoundation.github.io site because the links are much smaller there.
The link is squashed in under the main title and before the Intro title - so skimming the page skips over the link.
But then if you miss this link you come to the title 'In Other Written Languages' which then makes no sense - because you can't see the English list anywhere.
I've create a 'Books' section so that its similar to the 'Free Online Courses' and 'Cheat Sheets' and then put the English link at the top. This seems more logical and easier to skim.
Why is this valuable (or not)?
It's easier to find the main 'English' books link. More logical layout of the page. Consistency of titles.
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:
Followup