Improve Japanese resource #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed an error in alphabetical order. |
|
Sorry, I missed one 😅 |
davorpa
requested changes
Sep 20, 2021
|
|
||
|
|
||
| #### AngularJS | ||
|
|
||
| > :information_source: See also … [Angular](#angular) | ||
| > :information_source: 関連項目 - [Angular](#angular) |
There was a problem hiding this comment.
Ellipsis is part of crosslinks proposal #5535
Suggested change
| > :information_source: 関連項目 - [Angular](#angular) | |
| > :information_source: 関連項目 … [Angular](#angular) |
|
|
||
|
|
||
| #### Angular | ||
|
|
||
| > :information_source: See also … [AngularJS](#angularjs) | ||
| > :information_source: 関連項目 - [AngularJS](#angularjs) |
There was a problem hiding this comment.
Ellipsis is part of crosslinks proposal #5535
Suggested change
| > :information_source: 関連項目 - [AngularJS](#angularjs) | |
| > :information_source: 関連項目 … [AngularJS](#angularjs) |
There was a problem hiding this comment.
Comment welcome of crosslinks syntax. this gives us another option.
|
Thanks for translating |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve repo
For resources
Description
Similarly, I fixed the "/" and "index.html" at the end of the links.
I checked carefully to make sure that this would not break the links.
The names had changed, so I also reordered them.
Why is this valuable (or not)?
"free-programming-books-ja.md" will now follow the guidelines more closely than before.
How do we know it's really free?
I didn't add any books.
For book lists, is it a book? For course lists, is it a course? etc.
I didn't add any books.
Checklist:
Followup