Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sinhala courses #5934

Merged
merged 11 commits into from
Oct 6, 2021
Merged

added sinhala courses #5934

merged 11 commits into from
Oct 6, 2021

Conversation

Ttecs
Copy link
Contributor

@Ttecs Ttecs commented Oct 5, 2021

What does this PR do?

Add resources

For resources

sinhala tutorials for ASP.NET core ReactJs HTML/CSS java

Description

this tutorials will help for sinhala students to understand easily

Why is this valuable (or not)?

 valuable because it helps to share and improve knowledge 

How do we know it's really free?

  because it is youtube resourses

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa self-requested a review October 5, 2021 16:07
courses/free-courses-sl.md Outdated Show resolved Hide resolved
courses/free-courses-sl.md Outdated Show resolved Hide resolved
courses/free-courses-sl.md Outdated Show resolved Hide resolved
courses/free-courses-sl.md Outdated Show resolved Hide resolved
courses/free-courses-sl.md Outdated Show resolved Hide resolved
courses/free-courses-sl.md Outdated Show resolved Hide resolved
@davorpa davorpa added the question Needs clarification by involved users / reviewers label Oct 5, 2021
@davorpa
Copy link
Member

davorpa commented Oct 5, 2021

Welcome Sri-Lanka 🤗

It's a good moment to make some changes. When done, request for a review again using GitHub 🔃 button.


@vhf @eshellman This locale is not supported yet

https://github.com/SethFalco/free-programming-books-lint/blob/b72812e3cf51e0dce322a30d465f50ee618f3d0c/lib/lint.js#L18-L57

@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested conflicts Conflict(s) need to be resolved labels Oct 5, 2021
Ttecs and others added 7 commits October 5, 2021 23:00
Update courses/free-courses-sl.md v3

Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
Update courses/free-courses-sl.md v4

Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
Update courses/free-courses-sl.md v5

Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
Update courses/free-courses-sl.md v6

Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
Update courses/free-courses-sl.md v6

Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
Update courses/free-courses-sl.md v7

Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
Update courses/free-courses-sl.md v8
@Ttecs Ttecs requested a review from davorpa October 5, 2021 17:40
@Ttecs
Copy link
Contributor Author

Ttecs commented Oct 5, 2021

thank you for the guidence 😊

@davorpa davorpa requested review from eshellman and davorpa and removed request for davorpa October 5, 2021 18:55

### JavaScript

<!-- Waiting to add in -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no empty categories

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshellman It's there are like this in

I suggest this change to mantain lists with same TOC more or less. But you decide

@eshellman eshellman removed the conflicts Conflict(s) need to be resolved label Oct 6, 2021
resolved empty catogory
@Ttecs Ttecs requested a review from eshellman October 6, 2021 03:25
@davorpa davorpa mentioned this pull request Oct 6, 2021
39 tasks
@eshellman eshellman merged commit 9f935d2 into EbookFoundation:master Oct 6, 2021
@eshellman
Copy link
Collaborator

Sinhala!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants