Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .Net Url #6673

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Update .Net Url #6673

merged 4 commits into from
Jan 17, 2022

Conversation

MahmoudHamdy00
Copy link
Contributor

As the previose was 404 not found

What does this PR do?

Add resource(s) or just correct it for the same resource

For resources

Description

it's the same resource used for C# and it was already added but the url is wrong

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

As the previose was 404 not found
Copy link
Member

@LuigiImVector LuigiImVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this resource should be moved to the C# category on the file free-programming-books-langs.md

@LuigiImVector LuigiImVector added 👀 Needs Review Is this really a good resource? Reviews requested. question Needs clarification by involved users / reviewers labels Jan 15, 2022
@MahmoudHamdy00
Copy link
Contributor Author

@LuigiImVector it already exists in C# category but on the same file

@LuigiImVector
Copy link
Member

We are waiting for a response from some other staffer to figure out what to do. If you need to move it to the other file you also delete the link in the C# category of this file.

@davorpa
Copy link
Member

davorpa commented Jan 15, 2022

@LuigiImVector comparing with archived version but it carry on having a handbook and interactive content so... I think leave it in the courses file. Moreover, the matrix Epicodus is like a learning platform.

LATEST BROKEN BACKUP: https://web.archive.org/web/20190115121159/https://www.learnhowtoprogram.com/net

I agree with move it to C# section and if this is the last remove .NET section and also from index

@eshellman
Copy link
Collaborator

This might be a good place to use the crosslink syntax #5535 that lets us remove the dead link and leave the heading.

@davorpa
Copy link
Member

davorpa commented Jan 15, 2022

This might be a good place to use the crosslink syntax #5535 that lets us remove the dead link and leave the heading.

Nice good point. Preparing suggestion 😉

courses/free-courses-en.md Show resolved Hide resolved
@eshellman
Copy link
Collaborator

Sorry if we were not clear; since it's a duplicate, the link to the course should be removed, and replaced with the crosslink to c#. Alternatively, if the course is more a .net course than a c# course, and use the updated link in .net and remove it from c# (adding a crosslink to c#)

courses/free-courses-en.md Outdated Show resolved Hide resolved
@davorpa davorpa removed 👀 Needs Review Is this really a good resource? Reviews requested. question Needs clarification by involved users / reviewers labels Jan 17, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Jan 17, 2022
Thats is, 2 empty lines between headings / sections
@eshellman eshellman merged commit 6ac3f6f into EbookFoundation:main Jan 17, 2022
@davorpa davorpa added the 🗣️ locale:en Resources addressing "English" language label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:en Resources addressing "English" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants