Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused requirements-sparseattention #1177

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

segyges
Copy link
Contributor

@segyges segyges commented Mar 8, 2024

  • Removes this requirements file
  • Removes reference to it in the dockerfile
  • Also removes protobuf from the dockerfile since it is apparently unused and I noticed it
  • Causes confusion and possible problems while installing since it will force a downgrade of Triton
  • If downgrading Triton is actually essential I am wrong and this PR should be rejected.

@segyges segyges marked this pull request as draft March 8, 2024 17:55
@segyges
Copy link
Contributor Author

segyges commented Mar 8, 2024

This needs to cook more, apparently protobuf is actually used, I think we probably want to change the version of flashattention.

@Quentin-Anthony
Copy link
Member

Removing sparse attn from Dockerfile + removing the Dockerfile Flash mismatch was just handled in #1175, and as you mentioned we still need protobuf.

I would, however, still be interested in just updating the version of Flash to be consistent with the Dockerfile + removing requirements/requirements-sparseattention.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants