-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow request managers to delete data from sonarr/radarr #644
base: develop
Are you sure you want to change the base?
Conversation
oh very cool. very nice idea |
@xabufr who can request a deleting? |
Any person with the |
So now a user who has permission could simply delete the requested film from every other user? when he has the rights for that? |
Wouldn't it be better if everyone could delete their own requested movie or TV shows just as a suggestion |
Yes, any user that can 'manage requests' can delete any request. That was already the case, this PR just add a button to allow the user to also delete request's data, but it don't modify necessary rights.
There is currently no permission to delete you own requests I think (and no button for that), this would require more work, I did this PR as a quick/easy new feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works like a charm, just remove the renaming change on en.json (overseerr to jellyseerr) and the change on fr.json causing weblate trouble please
@Gauvino I removed the bad commit for the en.json file, but for the new translation keys where should I put them? |
You just keep the translation keys on the en.json, remove the change in fr.json |
done ! |
Description
Allow users who have the
MANAGE_REQUESTS
right to delete media files.I've done that on the request list to have a quick access to this feature.
This doesn't need to change the API because the API already only requires
MANAGE_REQUESTS
for this call.Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed
Related to: