Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow request managers to delete data from sonarr/radarr #644

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

xabufr
Copy link

@xabufr xabufr commented Feb 2, 2024

Description

Allow users who have the MANAGE_REQUESTS right to delete media files.
I've done that on the request list to have a quick access to this feature.

This doesn't need to change the API because the API already only requires MANAGE_REQUESTS for this call.

Screenshot (if UI-related)

image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

Related to:

@xabufr xabufr marked this pull request as ready for review February 2, 2024 22:29
@Panda260
Copy link

Panda260 commented Feb 3, 2024

oh very cool. very nice idea

@Panda260
Copy link

@xabufr who can request a deleting?
Only that person who also requested that same movie/tv show?

@xabufr
Copy link
Author

xabufr commented Feb 19, 2024

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

@Panda260
Copy link

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

So now a user who has permission could simply delete the requested film from every other user? when he has the rights for that?

@Panda260
Copy link

Wouldn't it be better if everyone could delete their own requested movie or TV shows just as a suggestion

@xabufr
Copy link
Author

xabufr commented Feb 22, 2024

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

So now a user who has permission could simply delete the requested film from every other user? when he has the rights for that?

Yes, any user that can 'manage requests' can delete any request. That was already the case, this PR just add a button to allow the user to also delete request's data, but it don't modify necessary rights.

Wouldn't it be better if everyone could delete their own requested movie or TV shows just as a suggestion

There is currently no permission to delete you own requests I think (and no button for that), this would require more work, I did this PR as a quick/easy new feature.

Copy link
Contributor

@Gauvino Gauvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works like a charm, just remove the renaming change on en.json (overseerr to jellyseerr) and the change on fr.json causing weblate trouble please

@xabufr
Copy link
Author

xabufr commented Apr 18, 2024

@Gauvino I removed the bad commit for the en.json file, but for the new translation keys where should I put them?

@Gauvino
Copy link
Contributor

Gauvino commented Apr 18, 2024

@Gauvino I removed the bad commit for the en.json file, but for the new translation keys where should I put them?

You just keep the translation keys on the en.json, remove the change in fr.json

@xabufr
Copy link
Author

xabufr commented Apr 18, 2024

done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants