Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix to use strict equality #2426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

penicillin0
Copy link

Thank you for everything.

To prevent unexpected behavior due to implicit type conversion, I have made use of the strict equality operator.

This is my first time contributing to this repository, so please let me know if there are any oddities.

@Johan-dutoit
Copy link
Collaborator

Hi @penicillin0, thanks for the contribution and welcome to the community!

The convenient thing about not using strict equality checks, is that it checks both null and undefined in one go.

Personally, I prefer strict checks, however with this change we need to consider the different flows here. e.g. what will happen if we a null message is sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants