fix: use messages from props instead of state #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwersolangi
suggested changes
Aug 26, 2023
There was a problem hiding this comment.
LGTM!
I was facing the same issue on React Native Web on Expo, where, messages from props are appearing in console.logs, however, the state was not being updated. So, I think that this approach is good, however, if we use useCallback hook in the renderMessages function and pass messages as dependency array would make sure the re-render if any change happens in messages props.
|
This seems to solve #2411. |
this is the problem I had on the web too! |
|
why is this not merged yet? |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's unclear why the messages were attached to state, but there was some effect resetting them, so the chat view was empty, even if it had messages.
the message container now uses the messages from props.