Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Launcher Theme Selector plugin #2448

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Odotocodot
Copy link
Contributor

A plugin to quickly change the current Flow Launcher theme.

image

If someone has a better suggestion for the default action keyword rather than flowtheme, would love to hear it. Was a bit apprehensive in using theme 🤷‍♂️ .

@jjw24
Copy link
Member

jjw24 commented Nov 30, 2023

Great idea. I think this plugin would be best served by publishing to the Store. We can have a look at exposing the needed methods via the API.

@taooceros
Copy link
Member

Great idea. I think this plugin would be best served by publishing to the Store. We can have a look at exposing the needed methods via the API.

I feel like we can allow this plugin to be built in. Thememanager is pretty internal.

@jjw24
Copy link
Member

jjw24 commented Nov 30, 2023

Well yes and no, it's directly referencing the core project, ideal design is to have even the default plugins as self contained.

@taooceros
Copy link
Member

Well yes and no, it's directly referencing the core project, ideal design is to have even the default plugins as self contained.

Some of our internal stuff uses the plugin interface for receiving query, which I think is a pretty good idea. I am not sure whether exposing everything to the interface is a very good idea. PublicAPI sometimes can be the curse as we may want to maintain backward compatibility.

@jjw24
Copy link
Member

jjw24 commented Mar 28, 2024

Well I think at least this functionality is a good one to enable plugins to use. Remember the more plugins we pack the more we need to maintain and the bigger the size eventually get. More ideal to encourage plugin development.

@taooceros
Copy link
Member

Well I think at least this functionality is a good one to enable plugins to use. Remember the more plugins we pack the more we need to maintain and the bigger the size eventually get. More ideal to encourage plugin development.

well a plugin only takes 400k size...which should be pretty neglectable. and this feature seems to be good to built in.

@taooceros
Copy link
Member

@Odotocodot isn't you also need to add the plugin folder to the solution?

Copy link

github-actions bot commented Apr 1, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (4)

flowtheme
Odotocodot
Reloadable
Segoe

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Odotocodot/Flow.Launcher.git repository
on the flow-theme-selector-plugin branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8510417023/attempts/1'
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24
Copy link
Member

jjw24 commented Apr 6, 2024

Well I think at least this functionality is a good one to enable plugins to use. Remember the more plugins we pack the more we need to maintain and the bigger the size eventually get. More ideal to encourage plugin development.

well a plugin only takes 400k size...which should be pretty neglectable. and this feature seems to be good to built in.

What about putting this functionality in the Sys plugin since it has flow related functionalities like open log file and reload data etc.

@Odotocodot
Copy link
Contributor Author

Sorry ive been busy with uni!

Well I think at least this functionality is a good one to enable plugins to use. Remember the more plugins we pack the more we need to maintain and the bigger the size eventually get. More ideal to encourage plugin development.

well a plugin only takes 400k size...which should be pretty neglectable. and this feature seems to be good to built in.

What about putting this functionality in the Sys plugin since it has flow related functionalities like open log file and reload data etc.

So move to be inside the sys plugin?

@Odotocodot isn't you also need to add the plugin folder to the solution?

Im not sure its needed? or im confused... its be a while

@jjw24
Copy link
Member

jjw24 commented May 17, 2024

So move to be inside the sys plugin?

I would say ideally exposing the methods via the plugin API would be the best so people can build plugin around it, but this change can be complicated, so putting it in the Sys plugin is the next best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants