Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Velopack #2616

Draft
wants to merge 66 commits into
base: dev
Choose a base branch
from
Draft

Migrate to Velopack #2616

wants to merge 66 commits into from

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Mar 24, 2024

Velopack (https://velopack.io/) is the successor of Cloud.Squirrel (https://github.com/clowd/Clowd.Squirrel)

Several change in this pr

  1. Remove shortcut related function https://docs.velopack.io/integrating/shortcuts
  2. Implement a custom restart script which doesn't depend on the updater (which should not be the use case anyway). This allows restart be called at dev environment (breaking change).
  3. Create the portable data folder if the package is not inside %LocalAppData% as velopack will pack the portable version for us, which doesn't allow us to modify (easily) to insert a custom folder.
  4. The post_build script is modified to add information about channel. Prerelease repo will have win-x64-prerelease channel, while the main repo will have win-x64-stable channel. https://docs.velopack.io/packaging/channels
  5. It also contains an experimental github action CI, which has a faster build time and larger concurrency allowance.

Todo:

  • Cleanup post_build script. Build Portable is no longer needed as that will be handled by vpk pack
  • Implement the logic of switching channel (maybe can delay to future).

@taooceros taooceros changed the title Velopack Migrate to Velopack Mar 24, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

# Conflicts:
#	.github/actions/spelling/expect.txt

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@taooceros taooceros force-pushed the velopack branch 2 times, most recently from 302ffcb to 6c3bcdc Compare March 29, 2024 17:57

This comment has been minimized.

@VictoriousRaptor
Copy link
Contributor

vpk: D:\a\Flow.Launcher\Flow.Launcher\Scripts\post_build.ps1:126
Line |
126 | vpk pack --packVersion $version --packDir $input --packId FlowLau …
| ~~~
| The term '~/.dotnet/tools/vpk.exe' is not recognized as a name of a cmdlet, function, script file, or executable
| program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
| again.

Looks like something's broken but I don't have any idea.

@taooceros
Copy link
Member Author

vpk: D:\a\Flow.Launcher\Flow.Launcher\Scripts\post_build.ps1:126
Line |
126 | vpk pack --packVersion $version --packDir $input --packId FlowLau …
| ~~~
| The term '~/.dotnet/tools/vpk.exe' is not recognized as a name of a cmdlet, function, script file, or executable
| program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
| again.

Looks like something's broken but I don't have any idea.

Previously the vpk installation takes 30s, so I add a cache, but weird, it should at least run the install🤔

/// <param name="subPath"></param>
/// <param name="basePath"></param>
/// <returns></returns>
public static bool IsSubPathOf(this string subPath, string basePath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a dup of PathContains()

@jjw24 jjw24 marked this pull request as draft May 22, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants