New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Velopack #2616
base: dev
Are you sure you want to change the base?
Migrate to Velopack #2616
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # .github/actions/spelling/expect.txt
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
302ffcb
to
6c3bcdc
Compare
This comment has been minimized.
This comment has been minimized.
Looks like something's broken but I don't have any idea. |
Previously the vpk installation takes 30s, so I add a cache, but weird, it should at least run the install🤔 |
/// <param name="subPath"></param> | ||
/// <param name="basePath"></param> | ||
/// <returns></returns> | ||
public static bool IsSubPathOf(this string subPath, string basePath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a dup of PathContains()
Velopack (https://velopack.io/) is the successor of Cloud.Squirrel (https://github.com/clowd/Clowd.Squirrel)
Several change in this pr
%LocalAppData%
as velopack will pack the portable version for us, which doesn't allow us to modify (easily) to insert a custom folder.win-x64-prerelease
channel, while the main repo will havewin-x64-stable
channel. https://docs.velopack.io/packaging/channelsTodo:
vpk pack