Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code separation in the settings window #2674

Merged
merged 51 commits into from
May 23, 2024

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Apr 27, 2024

What's the PR

  • Split the long code/xaml in the settings window.
    • Let each code be managed separately per menu.
  • Change TabControl to NavigationView
  • Reduced UI-related code with Custom Control

Todo

  • Split Pages
  • Split Code
  • Add DirectX-specific settings
    • Settings window DIRECTX is currently turned off due to startup freezing issues.
    • Since it affects the settings window animation, we also need a setting to turn the animation on and off based on this setting.
      • Will be working on separate PR.

WIP

  • About pane
    • Tested
  • General pane
    • Tested
  • Hotkeys pane
    • Tested
  • Plugins pane
    • Tested
  • Plugin store pane
    • Tested
  • Proxy pane
    • Tested
  • Theme pane
    • Tested
  • Figure out what to do with SettingWindowViewModel
  • Clean up code-behind of the SettingWindow.xaml.cs
    • Tested

Test Cases

  • Each page controls(Button, ListBox, ETC...) should work properly.

- Adjust Navigation Style
- Add General.xaml
@onesounds onesounds added Code Refactor kind/ui related to UI, icons, themes, etc labels Apr 27, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Yusyuriv Yusyuriv marked this pull request as ready for review May 22, 2024 04:16
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ check-file-path 1
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@onesounds onesounds merged commit 7ccf109 into Flow-Launcher:dev May 23, 2024
3 checks passed
@jjw24 jjw24 added the enhancement New feature or request label May 24, 2024
@jjw24 jjw24 added this to the 1.19.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Refactor enhancement New feature or request kind/ui related to UI, icons, themes, etc
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants