New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Media Player Warning #2683
base: dev
Are you sure you want to change the base?
Conversation
Would this be better? "Windows Media Player is unavailable and is required for sound effects. Please check your installation." |
Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>
maybe try something like this https://github.com/mobiletechtracker/NetCoreAudio? |
Adding a new dependency to play a single sound sounds wrong to me. |
- fix warning visibility
…auncher into AlertWithoutWMP
|
|
@onesounds do you want to abstract this piece out to a usercontrol? |
I am going to enable squash and merge into one commit in case we need to get this out sooner. |
not now. |
0186d88
to
490bf59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VictoriousRaptor can we move the check media player even higher, rather than when main window initializes maybe when we actually starting up the application? Put the check result as a constant variable maybe in https://github.com/Flow-Launcher/Flow.Launcher/blob/dev/Flow.Launcher.Infrastructure/Constant.cs or user settings class (but don't persist it to disk).
If user reinstalls the media player to fix the problem they can restart flow.
0edc7f1
to
2c3e1bf
Compare
Need to work on UI to match split setting pr. Will be worked on after split setting merge. |
What's the PR
Fix BUG: Sound Effect broken on v1.18 #2682
If WMP doesn't exist on your system and can't adjust volume, it will warn and guide you beforehand.
Check if the executable of Windows Media Player(Legacy) exists by reading registry and turn it on/off.
SoundPlayer
to play sound if there no WMPMore Info
I am upset with the following situation 🤬