-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons]Revision of TechDraw Icons #14145
base: main
Are you sure you want to change the base?
Conversation
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionArcLengthAnnotation.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionChangeLineAttributes.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCircleCenterLines.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionAreaAnnotation.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCascadeHorizDimension.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCreateHorizChainDimension.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCreateHorizChamferDimension.svg
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also change these icons for new page and new from template (folder icon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, I will come to them too.
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCircleCenterLines.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionChangeLineAttributes.svg
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other changes are good. Few icons missing for all TD ones :)
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCreateHorizChamferDimension.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCreateVertChamferDimension.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionCircleCenterLines.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionChangeLineAttributes.svg
Show resolved
Hide resolved
src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionDecreaseDecimal.svg
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some more issues, I've commented on the icons.
In general:
- align them to the pixel grid where possible, at least for all straight lines
- check stroke sizes. If you always use 2 and 1 they align easy to the pixel grid, don't look blurred and it looks consistent.
I find it very exhausting this back and forth and it seems with every change something else seems to break again. Most points were mentioned often enough, also on other PRs. I don't want to check each icon carefully after each new commit.
@kadet1090 FYI, maybe you can weigh in as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here. it's too similar to centerlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the yellow stroke is smaller than in the other icons (e.g. diameter icon above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not very legible (light blue on light grey background). Maybe just get rid of the grey rectangle at all, what should it depict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should represent selecting a line type. TechDraw_DecorateLine has the same icon. Actually, this icon is another version of that icon divided into two parts. Here you select the line and replace it with the other tool. Changing the line weights may help, or a gear may be placed to indicate that the adjustment has been made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arc was removed in order not to raise any questions about the use of the tool. This tool can be used for anything area related. This makes it necessary to use a broader representation of the area. You are right about the regulation of the dimensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why do you use an circle segment in the other area tool? src/Mod/TechDraw/Gui/Resources/icons/TechDraw_ExtensionAreaAnnotation.svg
You contradict yourself here. It should be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because that tool can only be used in areas created with arc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only icon iirc where the point has no dark outline and is fuesed with the yellow lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are looking at a dark theme, you will see the yellow line. If you are looking at a light theme, you will see the black line. There is actually no line for this tool. A tool made to show the angle of three points that do not have a line between them. In the old ikon, a lower opacity version of the currently used line was used. I envisioned something like this, dedicated to the thin lines in technical drawings, as I thought it made it more easy to understand. The existence of the line is obvious, but the user is informed that this is not important. In this way, the user understands more easily that the tool can be used for points that are not connected by lines. We tried gray in past changes. But it wasn't good enough at delivering that purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you've mixed it up with this icon src/Mod/TechDraw/Gui/Resources/icons/TechDraw_3PtAngleDimension.svg but I've commented here on src/Mod/TechDraw/Gui/Resources/icons/TechDraw_AngleDimension.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it was used this way before. So I continued this. Maybe we should convert other icons to this shape. This is a question that needs to be asked in terms of style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the inner yellow stroke on the arc is too thin and not really legible, should be the same size as the other arc icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what the grey rectangle should mean, I think the new icon is more confusing than the old one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why there is a dot in the circle now?
I go over all the icons one by one. It is currently in the draft stage. If you have an opinion please let me know.
Because the documents may be incomplete, icons may highlight the wrong things. If you think there is a wrong emphasis, write it down.
I also decided to name the icon set Technical FREEhand Drawing.
Solve: #14203