Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility of some group commands #14191

Merged
merged 2 commits into from
May 23, 2024

Conversation

wwmayer
Copy link
Contributor

@wwmayer wwmayer commented May 21, 2024

Several group commands are active but require an active document to work. This PR overrides the method isActive() to disable the commands if no active document exists.

The affected commands are:

  • Std_ViewGroup
  • Std_LinkActions
  • PartDesign_CompDatums
  • PartDesign_CompSketches
  • Sketcher_CompLine
  • Sketcher_CompCreateArc
  • Sketcher_CompCreateConic
  • Sketcher_CompCreateFillets
  • Sketcher_CompCurveEdition
  • Sketcher_CompSlot
  • Sketcher_CompHorVer
  • Sketcher_CompToggleConstraints

Several group commands are active but require an active document to work. This PR overrides the method isActive() to
disable the commands if no active document exists.

The affected commands are:
* Std_ViewGroup
* Std_LinkActions
* PartDesign_CompDatums
* PartDesign_CompSketches
@github-actions github-actions bot added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Design Related to the Part Design Workbench labels May 21, 2024
The affected commands are:
* Sketcher_CompLine
* Sketcher_CompCreateArc
* Sketcher_CompCreateConic
* Sketcher_CompCreateFillets
* Sketcher_CompCurveEdition
* Sketcher_CompSlot
* Sketcher_CompHorVer
* Sketcher_CompToggleConstraints
@wwmayer wwmayer merged commit 83d91d6 into FreeCAD:main May 23, 2024
9 checks passed
@wwmayer wwmayer deleted the fix_group_commands branch May 23, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Design Related to the Part Design Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant