Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

样式优化,解决有些demo 不可用的问题(天气),解决有些题目失效无法解答的问题(twitch),解决有些工具无法使用的问题(c9.io) #521

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

ZhichengChen
Copy link

更改了html 课程的样式,预览:http://fcc.chenzhicheng.com/challenges/say-hello-to-html-element
将facebook 群组改为微信群组
/challenges/show-the-local-weather demo 偶尔不能正常显示
/challenges/use-the-twitchtv-json-api 课程说明链接失效
BackEnd 课程里c9.io 改版后变化较大,需要购买亚马逊服务器,完成课程难度较高,试用多家后最终选择codeanywhere,并制作替换了了gif 教程,预览: http://fcc.chenzhicheng.com/challenges/get-set-for-our-back-end-development-projects

Chenzc added 5 commits May 14, 2018 18:23
c9.io 变化较大,完成课程难度较高
使用多家后选择codeanywhere
fork 计划及已完成功能说明
@S1ngS1ng S1ngS1ng requested a review from wudifeixue May 25, 2018 17:59
@wudifeixue
Copy link
Contributor

好大的一个pr。。我要回家build一下慢慢看看

@S1ngS1ng
Copy link
Contributor

@ZhichengChen 麻烦问下,之前的 weather app 有什么问题呢?啥时候会无法显示?

@ZhichengChen
Copy link
Author

@S1ngS1ng 您好,注意到您使用了 ipinfo.io 的api ,很赞,但是在国内环境下还不能访问,而且不再GFWList 默认列表里,所以我必须开启全局vpn 模式,或者手动添加该地址,才能显示(非本地,而是vpn 服务器所在地址的天气),否则天气会无法显示

@S1ngS1ng
Copy link
Contributor

@Becavalier Consider including this PR for beta release

@S1ngS1ng
Copy link
Contributor

@ZhichengChen 先谢谢你的 PR。由于最近计划做新版本的更新和 beta release,很抱歉我们现在没法 merge 你的代码。一方面 file changes 比较多,另一方面我们需要目前上线的 codebase 来做比较。

目前计划新版本会在放在另一个 branch 做开发,所以你的这个 PR 先不着急关

@ZhichengChen
Copy link
Author

好的,感谢您的关注

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants