Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added graphcomment cloud comments #834

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

wuniversales
Copy link
Contributor

@wuniversales wuniversales commented Oct 2, 2020

I have tested the code and it works.

@wuniversales
Copy link
Contributor Author

Hmm, I don't know whether to add options to choose the background color of the button, the color of the letter and the width of the theme...
I think it will be better...

Better visual appearance and more customization options.
Added more customization
@wuniversales
Copy link
Contributor Author

wuniversales commented Oct 2, 2020

Added more customizations...

imagen

@wuniversales
Copy link
Contributor Author

wuniversales commented Oct 2, 2020

I think this is done. ;)

Edited...

I just thought that it doesn't make sense to add two comment servers at the same time, so I have added an option to "select comment server", depending on the chosen server the settings change ...

@wuniversales
Copy link
Contributor Author

wuniversales commented Oct 2, 2020

I have added an option to select the server for comments.

I have set "graphcomment" by default because it has more privacy.

In principle I think everything is done...

I put some images:
imagen
imagen
imagen

@wuniversales
Copy link
Contributor Author

It's ready

@wuniversales
Copy link
Contributor Author

Now it is more stable since it works with the identifier of the publii.

@wuniversales
Copy link
Contributor Author

Hello,
Will my enhancements ever be implemented?
Many users have requested these functions (I include myself) and nobody accepts my pr since I put it in 2020.
Like my other pr related to improving searches, which many users also request it, and the changes I made are not implemented ...
Greetings

@bobmitro
Copy link
Collaborator

Hi @wuniversales,
Thank you for the contribution and the work you did.
However, we decided not to implement it directly in themes now as we are going to release it as a plugin. This year will bring plugin support and I think this kind of addons should be released as a theme extension (plugin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants