Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified emptyOutputDir in a way that we can now avoid removing files… #864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SKOSCIE
Copy link

@SKOSCIE SKOSCIE commented Nov 18, 2020

modified emptyOutputDir in a way that we can now avoid removing files listed in the settings.
This is especially helpful when we share same repository and have nested websites / systems. Normally Publii would delete whole content of the output DIR except media folder.

image

… listed in the settings. This is especially helpful when we share same repository and have nested websites / systems.
@dziudek
Copy link
Collaborator

dziudek commented Dec 14, 2020

Hi, thank you for your pull request - I will analyze it, add improvements and then I will include it in the next Publii release :)

@dziudek dziudek self-requested a review December 14, 2020 17:03
@dziudek dziudek self-assigned this Dec 14, 2020
@Adrien-Luxey
Copy link

Does this solve #691 ? I would coin that as extremely urgent, as any new user can potentially be a victim of Publii (as per @superboum 's comment). Don't alienate users :o

@dziudek
Copy link
Collaborator

dziudek commented Feb 4, 2021

@Adrien-Luxey - no it is not a solution, but I will address that issue in the upcoming v.0.38

@dziudek
Copy link
Collaborator

dziudek commented Mar 6, 2021

Hi,

I have reanalysed this feature and I have discovered that it is not necessary as it duplicates the File Manager functionality.

This feature is dedicated to a case when user adds some files to the output directory. Publii removes content of this directory on every sync. But in fact user should not add files to the output directory manually at all. Instead user should use File Manager and there put files to include in the final output.

In my opinion we should avoid such situations and promote a proper way of adding files.

If I am wrong - please correct me :) I just want to avoid adding of functionality which duplicates existing features to keep the Publii UI as simple as possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants