Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve download_component to allow for resuming failed downloads #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastiabaro
Copy link

Hi! I made some changes to the download_component function to improve its functionality. Now, if a download fails, the function will attempt to resume the download from where it left off instead of starting from the beginning. This should help avoid having to download large files multiple times due to failed downloads.

I added an additional check to verify the MD5 hash of the downloaded file to ensure that it matches the expected value. If the hash does not match, the function will delete the partially downloaded file and attempt to download it again.

I also added a check to determine if the aria2c package is installed on the system, and if so, it will be used to download the file. If aria2c is not installed, the function will attempt to use curl or wget to download the file.

I hope these changes are helpful. Please let me know if you have any questions or concerns. Thank you!

@VVishion
Copy link

VVishion commented Apr 17, 2023

This worked for me after I had the md5's do not match error, because the download failed.

@sebastiabaro
Copy link
Author

This worked for me after I had the md5's do not match error, because the download failed.

Hi, thanks for commenting. Initially, the hash is checked before starting the download. If you've had problems before downloading the file, it's possible that you got that error by having an incomplete previous download as a residual file. I hope my solution has helped you to be able to install Photoshop on Linux.

@Partack
Copy link

Partack commented May 9, 2023

worked first time. thanks for fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants