Cycling dynamics in train mode #4337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to Feature request #3840 |
vlcvboyer
force-pushed
the
CyclingDynamicsInTrainMode
branch
from
cf2f006
to
5413ce7
Compare
vlcvboyer
force-pushed
the
CyclingDynamicsInTrainMode
branch
from
5413ce7
to
2a9b46b
Compare
Power sensors which deliver cycling dynamics such as power start angle, rider position, etc. are supported during hometrainer session. Goldencheetah requests power sensor capabilities and, when available, request the sensor to enable them (power phase, pedal position, etc. and 8Hz transmission mode which is mandatory when accessing those additional data pages)
The comment was not reflecting the up-to-date file content as per latest CSV header
Only target power was recorded in CSV records during hometrainer session. When not using ERG mode but slope mode then the data was lost. This patch take care of training mode to determine which data is to be recorded.
Allows to add fields in CSV file recorded during hometrainer session without impacting a lot of files in the code Historical first fields are still used to determine taht this file has been created by GoldenCheetah. During CSV parsing GoldenCheetah will use CSV header to determine which fields are part of the file and to locate the column which contain it
during hometrainer session
vlcvboyer
force-pushed
the
CyclingDynamicsInTrainMode
branch
from
2a9b46b
to
f81b70b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure power sensors in order to enable cycling dynamics data broadcast
Read the same during hometrainer session
Record them into csv and then into activity json
includes commits with few cosmetics in code
and evolution to CSV parser/writer in order to be more flexible to add fields in the future
and part of #4327 (one commit) which is required by this commits sequence