feat: Added all files for Fashion Trends Prediction app #560

devikamittal19 · 2024-04-19T09:52:16Z

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Follow the CONTRIBUTING Guide.
You are listed as the author in your notebook or README file.
- Your account is listed in CODEOWNERS for the file(s).
Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
Ensure the tests and linter pass (Run nox -s format from the repository root to format).
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: eliasecchig <115624100+eliasecchig@users.noreply.github.com> Co-authored-by: Thu Ya Kyaw <thuyakyaw@google.com> Co-authored-by: yadavj2008 <105886306+yadavj2008@users.noreply.github.com> Co-authored-by: anantnawal <67642890+anantnawal@users.noreply.github.com> Co-authored-by: Tom <tompakeman@google.com> Co-authored-by: QuantumMartin <31007551+quantumcode-martin@users.noreply.github.com> Co-authored-by: Arindam Banerjee <59955214+arindam-b@users.noreply.github.com> Co-authored-by: Megha Agarwal <agarwal22megha@gmail.com> Co-authored-by: Kristopher Overholt <koverholt@google.com> Co-authored-by: Patrick Marlow <kmaphoenix@gmail.com> Co-authored-by: Patrick Marlow <pmarlow@google.com> Co-authored-by: Kristopher Overholt <koverholt@gmail.com> Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Holt Skinner <holtskinner@google.com> Co-authored-by: Gábor Bakos <aborg0@users.noreply.github.com> Co-authored-by: rachael-ds <45947385+rachael-ds@users.noreply.github.com> Co-authored-by: Rajesh Thallam <rthallam@google.com> Co-authored-by: Lavi Nigam <98014943+lavinigam-gcp@users.noreply.github.com> Co-authored-by: Ivan Nardini <88703814+inardini@users.noreply.github.com> Co-authored-by: Romin Irani <1614870+rominirani@users.noreply.github.com> Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Leszek <24715532+uhcel@users.noreply.github.com> Co-authored-by: Kaz Sato <kazunori279@gmail.com> Co-authored-by: Katie McLaughlin <katie@glasnt.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erwin Huizenga <111493729+erwinh85@users.noreply.github.com> Co-authored-by: guruvittal <147344888+guruvittal@users.noreply.github.com> Co-authored-by: Ashley Xu <139821907+ashleyxuu@users.noreply.github.com> Co-authored-by: Megan O'Keefe <3137106+askmeegs@users.noreply.github.com> Co-authored-by: Chris Hanna <christopher.g.hanna@gmail.com> Co-authored-by: atta-goog <136734735+atta-goog@users.noreply.github.com> Co-authored-by: smitha-google <102045161+smitha-google@users.noreply.github.com> Co-authored-by: Gabe Rives-Corbett <395660+grivescorbett@users.noreply.github.com> Co-authored-by: Karl Weinmeister <11586922+kweinmeister@users.noreply.github.com> Co-authored-by: rocky lubbers <rocky.lubbers@gmail.com> Co-authored-by: Riccardo Carlesso <palladiusbonton@gmail.com> Co-authored-by: Pratimamishra-SSK <127853827+Pratimamishra-SSK@users.noreply.github.com> Co-authored-by: ronanmandel <ronanmandel@gmail.com> Co-authored-by: Boris-Wilfried <5323628+bwnyasse@users.noreply.github.com> Co-authored-by: Brenden Durham <bdurham.ai@gmail.com> Co-authored-by: Kara Greenfield <151587423+kgreenfield2@users.noreply.github.com> Co-authored-by: Sumukha Kaparthi <sumukhakaparthi@users.noreply.github.com> Co-authored-by: Preston Holmes <preston@ptone.com> Co-authored-by: alan blount <alan@zeroasterisk.com> Co-authored-by: G. Hussain Chinoy <ghchinoy@gmail.com> Co-authored-by: Hussain Chinoy <ghchinoy@google.com> Co-authored-by: Roy Arsan <roy.arsan@gmail.com> Co-authored-by: Kavitha Rajendran <karajendran@google.com> Co-authored-by: Eric Dong <itseric@google.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Polong Lin <polong-lin@users.noreply.github.com> Co-authored-by: eliasecchig <115624100+eliasecchig@users.noreply.github.com> Co-authored-by: yadavj2008 <105886306+yadavj2008@users.noreply.github.com> Co-authored-by: anantnawal <67642890+anantnawal@users.noreply.github.com> Co-authored-by: Tom <tompakeman@google.com> Co-authored-by: QuantumMartin <31007551+quantumcode-martin@users.noreply.github.com> Co-authored-by: Arindam Banerjee <59955214+arindam-b@users.noreply.github.com> Co-authored-by: Megha Agarwal <agarwal22megha@gmail.com> Co-authored-by: Kristopher Overholt <koverholt@google.com> Co-authored-by: Patrick Marlow <kmaphoenix@gmail.com> Co-authored-by: Patrick Marlow <pmarlow@google.com> Co-authored-by: Kristopher Overholt <koverholt@gmail.com> Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Holt Skinner <holtskinner@google.com> Co-authored-by: Gábor Bakos <aborg0@users.noreply.github.com> Co-authored-by: rachael-ds <45947385+rachael-ds@users.noreply.github.com> Co-authored-by: Rajesh Thallam <rthallam@google.com> Co-authored-by: Lavi Nigam <98014943+lavinigam-gcp@users.noreply.github.com> Co-authored-by: Ivan Nardini <88703814+inardini@users.noreply.github.com> Co-authored-by: Romin Irani <1614870+rominirani@users.noreply.github.com> Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Leszek <24715532+uhcel@users.noreply.github.com> Co-authored-by: Kaz Sato <kazunori279@gmail.com> Co-authored-by: Katie McLaughlin <katie@glasnt.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erwin Huizenga <111493729+erwinh85@users.noreply.github.com> Co-authored-by: guruvittal <147344888+guruvittal@users.noreply.github.com> Co-authored-by: Ashley Xu <139821907+ashleyxuu@users.noreply.github.com> Co-authored-by: Megan O'Keefe <3137106+askmeegs@users.noreply.github.com> Co-authored-by: Chris Hanna <christopher.g.hanna@gmail.com> Co-authored-by: atta-goog <136734735+atta-goog@users.noreply.github.com> Co-authored-by: smitha-google <102045161+smitha-google@users.noreply.github.com> Co-authored-by: Gabe Rives-Corbett <395660+grivescorbett@users.noreply.github.com> Co-authored-by: Karl Weinmeister <11586922+kweinmeister@users.noreply.github.com> Co-authored-by: rocky lubbers <rocky.lubbers@gmail.com> Co-authored-by: Riccardo Carlesso <palladiusbonton@gmail.com> Co-authored-by: Pratimamishra-SSK <127853827+Pratimamishra-SSK@users.noreply.github.com> Co-authored-by: ronanmandel <ronanmandel@gmail.com> Co-authored-by: Boris-Wilfried <5323628+bwnyasse@users.noreply.github.com> Co-authored-by: Brenden Durham <bdurham.ai@gmail.com> Co-authored-by: Kara Greenfield <151587423+kgreenfield2@users.noreply.github.com> Co-authored-by: Sumukha Kaparthi <sumukhakaparthi@users.noreply.github.com> Co-authored-by: Preston Holmes <preston@ptone.com> Co-authored-by: alan blount <alan@zeroasterisk.com> Co-authored-by: G. Hussain Chinoy <ghchinoy@gmail.com> Co-authored-by: Hussain Chinoy <ghchinoy@google.com> Co-authored-by: Roy Arsan <roy.arsan@gmail.com> Co-authored-by: Kavitha Rajendran <karajendran@google.com> Co-authored-by: Eric Dong <itseric@google.com>

holtskinner

See comments for specifics. In general, it seems like there is a lot of code in this app that could be simplified/cleaned up to make it more readable and simple. I'd recommend looking through to see what can be refactored/reduced.

gemini/sample-apps/fashion-trends-prediction/README.md

gemini/sample-apps/fashion-trends-prediction/app/data/chunks_local.json

gemini/sample-apps/fashion-trends-prediction/app/articles.py

gemini/sample-apps/fashion-trends-prediction/app/data_prep/create_new_data.py

gemini/sample-apps/fashion-trends-prediction/app/data_prep/dataProcessing.py

gemini/sample-apps/fashion-trends-prediction/app/pages/0_ Trend Prediction.py

gemini/sample-apps/fashion-trends-prediction/app/pages/1_Additional Tools.py

gemini/sample-apps/fashion-trends-prediction/app/pages/2_ ● Fashion Bot.py

gemini/sample-apps/fashion-trends-prediction/app/utils_standalone_image_gen.py

…into dev

Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>

…into dev

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…into dev

…ive-ai into pr/devikamittal19/560

holtskinner · 2024-05-15T18:51:56Z

gemini/sample-apps/fashion-trends-prediction/app/utils_standalone_image_gen.py

 # pylint: disable=R0913
 # pylint: disable=R0914
 # pylint: disable=R0912
+# pylint: disable=W0212


Is there a reason to have all of these disabled? The issues should really be addressed.

holtskinner · 2024-05-15T18:52:08Z

gemini/sample-apps/fashion-trends-prediction/app/pages/trend_prediction.py

@@ -291,21 +283,21 @@ def btn_pressed_callback(i_index: int) -> None:

                if country == "India":
                    st.write("#### Relevant Articles")
-                    none_found = True
+                    NONE_FOUND = True


Don't use all caps for a variable value.

the-data-guy and others added 5 commits December 20, 2023 22:06

Include full GCS path for gsutil command (GoogleCloudPlatform#154)

dad4f6d

removing this file to resolve conflict

78855ed

feat: Added all files for Fashion Trends Prediction app

62a3e06

devikamittal19 requested a review from a team as a code owner April 19, 2024 09:52

devikamittal19 requested a review from yil532 April 19, 2024 09:52

holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2024

holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2024

holtskinner requested changes Apr 19, 2024

View reviewed changes

holtskinner assigned devikamittal19 Apr 19, 2024

holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2024

linting changes

6ae07ab

devikamittal19 force-pushed the dev branch from 7051f68 to ee58b3c Compare April 20, 2024 05:26

devikamittal19 and others added 11 commits April 20, 2024 11:04

Merge branch 'dev' of https://github.com/devikamittal19/generative-ai …

65614ed

…into dev

Update gemini/sample-apps/fashion-trends-prediction/README.md

3d2b090

Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>

Update README.md

f3d912b

Update README.md

e88f7ca

Update README.md

4695e57

Update README.md

fd35ade

few changes based on comments

6d9fbfb

Merge branch 'dev' of https://github.com/devikamittal19/generative-ai …

9a73d44

…into dev

few changes based on comments

e69c154

Update README.md

001615f

Update config.py

744f1fa

holtskinner force-pushed the dev branch from 41331e0 to 744f1fa Compare April 22, 2024 16:09

feat: Added all files for Fashion Trends Prediction app

23fdbab

github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024

Merge branch 'main' into dev

3a2eda4

github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024

devikamittal19 added 2 commits May 15, 2024 12:16

linting changes

09c2952

Merge branch 'dev' of https://github.com/devikamittal19/generative-ai …

41dbe8d

…into dev