Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding API v2 Bigquery export samples #9291

Closed
wants to merge 55 commits into from
Closed

feat: Adding API v2 Bigquery export samples #9291

wants to merge 55 commits into from

Conversation

rafaelMurata
Copy link
Contributor

@rafaelMurata rafaelMurata commented Apr 16, 2024 •
edited by Sita04

Description

b/335222583

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Apr 16, 2024 •
edited

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: securitycenter Issues related to the Security Command Center API. labels Apr 16, 2024
@kweinmeister kweinmeister added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 17, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 17, 2024
@Sita04
Copy link
Contributor

Sita04 commented Apr 18, 2024

@rafaelMurata @RajviM I see this PR refactors the existing v1 samples. Acc to previous discussions, IIUC, we are trying to create new samples in addition to the existing ones right?

@rafaelMurata
Copy link
Contributor Author

rafaelMurata commented Apr 18, 2024 •
edited

@Sita04 @RajviM
revert done

@kweinmeister kweinmeister added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@Sita04
Copy link
Contributor

Sita04 commented Apr 24, 2024

@rafaelMurata Kindly address the test failures.

@rafaelMurata
Copy link
Contributor Author

rafaelMurata commented Apr 26, 2024 •
edited

@Sita04

Done.
Please try again.

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2024
@rafaelMurata
Copy link
Contributor Author

/gcbrun

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2024
Sita04
Sita04 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the snippets. Kindly merge once all tests pass.

security-command-center/snippets/src/main/java/vtwo/bigquery/CreateBigQueryExport.java Outdated Show resolved Hide resolved
security-command-center/snippets/src/main/java/vtwo/bigquery/UpdateBigQueryExport.java Outdated Show resolved Hide resolved
rafaelMurata and others added 2 commits May 7, 2024 09:33
@rafaelMurata @Sita04
Update security-command-center/snippets/src/main/java/vtwo/bigquery/C…
471722c 
…reateBigQueryExport.java

Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@rafaelMurata @Sita04
Update security-command-center/snippets/src/main/java/vtwo/bigquery/U…
3675818 
…pdateBigQueryExport.java

Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
grayside and others added 18 commits May 27, 2024 13:12
@grayside @rafaelMurata
chore(cloudrun): Cleanup deprecated sample Cloud Run Filesystem (Goog…
def983d 
…leCloudPlatform#9321)

The Cloud Run Filesystem sample app is no longer in use.
@irataxy @Sita04 @rafaelMurata
feat: refactor text-only Gemini prompt (GoogleCloudPlatform#9322)
d16f84f 
* feat: refactor text-only Gemini prompt

* fix line length errors

* update testcase

---------

Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@msilc @rafaelMurata
refactor(iam): update service account samples to use GAPIC library (G…
9524771 
…oogleCloudPlatform#9293)

* Service accounts snippets rewrote using a new library

* PR fix

* Added GetServiceAccount and GetServiceAccountKey snippets

* PR fix

* test fix

* PR fix

* Moved service accounts snippets to iam/snippets

* Removed unused dependency

* Updated copyright year

* PR fix

* Refactored disable/enable keys snippets

* PR fix

* Test fix

* AccessTests fix

* Imports fix

* stage1_testServiceAccountsList refactoring

* Revert "stage1_testServiceAccountsList refactoring"

This reverts commit 336fa98.

* licence headers update

* fix
@ssvir @rafaelMurata
unignore tests, rerun 5 times without failings (GoogleCloudPlatform#9329
711ee97 
)
@glaforge @rafaelMurata
feat(vertexai): support system instruction (GoogleCloudPlatform#9330)
063db2f 
* Remove the preview package
Add a function calling example

* Missing license header

* chore(Checkstyle tweak)

* Add missing region tag
Fix typo in project ID string

* Use the latest libraries-bom that references the 0.4.0 version of the google-cloud-vertexai SDK
Use the same example for the token count as in Python and Golang

* feat(vertexai): Multimodal snippets using Gemini 1.5

* feat(vertexai): Multimodal snippets using Gemini 1.5 (checkstyle and header tweaks)

* feat(vertexai): Multimodal snippets using Gemini 1.5 (incorporating feedback, fixing region tags, and clarifying comments)

* chore(vertexai): Update to the latest version of the libraries-bom

* chore(vertexai): tweak tests

* feat(vertexai): System instruction example

* feat(vertexai): Add region tag for system instruction test

* feat(vertexai): Add region tag for system instruction test (comment nit)

* feat(vertexai): Add region tag for system instruction test (non-predictable output, removing an assert)
@ssvir @rafaelMurata
spanner/r2dbc test(s) are failing GoogleCloudPlatform#8978 (GoogleClo…
70f3df1 
…udPlatform#9318)

adds creation of instance and only then creation of database, added after block to close delete instance, db and close all connections
@renovate-bot @rafaelMurata
chore(deps): update eclipse-temurin docker tag to v17.0.11_9-jre (Goo…
89c487e 
…gleCloudPlatform#9327)
@ssvir @rafaelMurata
moved files from "update IAM policy samples to use GAPIC library" PR (G…
f97340d 
…oogleCloudPlatform#9319)

* moved all files from "update IAM policy samples to use GAPIC library" PR to snippets module

* merge with main, create TestPermissionsTest

* remove unused test case

* added license header

* fix lint

* fix lint
@suztomo @rafaelMurata
chore: comment about how to instantiate logger variable in Cloud Run (G…
6501c8b 
…oogleCloudPlatform#9340)

This App.java is referenced in https://cloud.google.com/run/docs/samples/cloudrun-manual-logging#cloudrun_manual_logging-java. But the document does not explain how to instantiate and configure the logger variable.

https://cloud.google.com/run/docs/logging#run_manual_logging-java has the answer. So let's add the explanation in the source code comment.
@glasnt @rafaelMurata
fix: remove unused region tag eventarc_pubsub_dockerfile (GoogleCloud…
608d980 
…Platform#9328)
@rafaelMurata
feat: Adding API v2 Source samples (GoogleCloudPlatform#9299)
4801c50 
* add sources samples

* feat: sources samples v2

* improve readability

* improve comments

* adjustments for pull request
@vorburger @rafaelMurata
Joint String output variable declaration and use in Vertex AI TextInp…
d0af378 
…ut.java Snippet (GoogleCloudPlatform#9331)
@Sita04 @rafaelMurata
fix(aiplatform): Update NVIDIA_TESLA_K80 to NVIDIA_TESLA_T4 (GoogleCl…
cfc22c6 
…oudPlatform#9342)
@LukeSchlangen @iennae @rafaelMurata
add region tag for QuestionAnswer.java (GoogleCloudPlatform#9335)
0d06414 
* add region tag for QuestionAnswer.java

* fix: remove extraneous region tags; update comments

* fix: ensure that region tag includes the last }

---------

Co-authored-by: Jennifer Davis <sigje@google.com>
@skarukas @rafaelMurata
Update embedding tuning sample to use the v1.1.3 pipeline. (GoogleClo…
0c24b56 
…udPlatform#9333)
@lee1premium @rafaelMurata
fix: Use Alphabet 10k sample dataset. (GoogleCloudPlatform#9337)
d0b24dd
@glaforge @rafaelMurata
feat(vertexai): Update to gemini-1.5-flash-001 (GoogleCloudPlatform#9344
abb262a 
)

* feat(vertexai): Multimodal snippets using Gemini 1.5

* feat(vertexai): Multimodal snippets using Gemini 1.5 (checkstyle and header tweaks)

* feat(vertexai): Multimodal snippets using Gemini 1.5 (incorporating feedback, fixing region tags, and clarifying comments)

* feat(vertexai): Use gemini-1.5-flash-001 instead of the preview model

* Reset the initial backoff time to its original setting
@rafaelMurata
add mockito
e4c9c6a
@rafaelMurata rafaelMurata requested review from a team as code owners May 27, 2024 13:15
@rafaelMurata rafaelMurata mentioned this pull request May 27, 2024
Open
11 tasks
@rafaelMurata rafaelMurata reopened this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Sita04 Sita04

Labels
api: securitycenter Issues related to the Security Command Center API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet