Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add region tag for QuestionAnswer.java #9335

Merged
merged 3 commits into from
May 23, 2024
Merged

add region tag for QuestionAnswer.java #9335

merged 3 commits into from
May 23, 2024

Conversation

LukeSchlangen
Copy link
Member

@LukeSchlangen LukeSchlangen commented May 16, 2024 •
edited by iennae

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@LukeSchlangen LukeSchlangen requested review from yoshi-approver and a team as code owners May 16, 2024 19:59
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 16, 2024 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 16, 2024
@Sita04 Sita04 merged commit dade187 into main May 23, 2024
11 checks passed
@Sita04 Sita04 deleted the add-region-for-question-answer branch May 23, 2024 15:15
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
@LukeSchlangen @iennae @rafaelMurata
add region tag for QuestionAnswer.java (GoogleCloudPlatform#9335)
0d06414 
* add region tag for QuestionAnswer.java

* fix: remove extraneous region tags; update comments

* fix: ensure that region tag includes the last }

---------

Co-authored-by: Jennifer Davis <sigje@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae left review comments

@Sita04 Sita04 Sita04 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Sita04 Sita04

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukeSchlangen @iennae @Sita04