New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cancellation of drag actions in all tools where it's missing #1664
Fix cancellation of drag actions in all tools where it's missing #1664
Conversation
@Keavon everything but the filltool (and artboardtool which is in a separate PR) should be fixed by this PR. I plan on maybe refactoring the solution in ArtBoardTool based on what I learnt from other tools (nothing serious, just removing a long pattern match with a MessageDiscriminant) |
…ortTransaction while aborting select tool
eb1acd2
to
4d271b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thrilled that you were able to implement this with so few lines of code. Simplicity is key!
Closes #1657, closes #1663
A bigger PR focused on fixing multiple tools at once along with other issues discovered.