New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Artboard tool respond to Abort keys #1661

Closed

milan-sedivy wants to merge 3 commits into GraphiteEditor:master from milan-sedivy:abort-artboard-tool

Contributor

milan-sedivy commented Mar 9, 2024 •

edited

Part of #1657

This is the last tool that I will do in a separate pull request as most of the logic is easy to implement.

Implemented 3 aborts:

When resizing
When drawing
When moving (I've seen it implemented with other tools)

milan-sedivy and others added 3 commits

March 9, 2024 15:07


          Make Artboard tool respond to Abort keys

e67ca8a


          Refactor patter matching so that it takes advantage of MessageDiscrim…

f4a86cc

…inants


          Merge branch 'master' into abort-artboard-tool

57fb81b

Member

Keavon commented Mar 10, 2024

I moved these changes into #1664 and cleaned up fn actions() to reuse the common code. That issue can now supersede this one.

Keavon closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment